Fixed error when nodeCommands[0] is undefined in Model.updateColor() #9271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9273
Fixes #8394
Fixes #9278
Model.js was missing code to handle the case in updateColor where
nodeCommands.length == 0
.Background
For some reason that I ran out of time to diagnose, this PR to TerriaJS is hitting a case where
nodeCommands[0]
in Model.updateColor() is undefined. This seems like something that shouldn't happen, but this PR stops Cesium from throwing an error and doesn't seem to have any negative consequences.