More robust negativePiToPi, zeroToTwoPi, and mod #9354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CesiumMath.negativePiToPi
,CesiumMath.zeroToTwoPi
, andCesiumMath.mod
were applying extra math to values that were already in the valid range, causing floating point error.For example:
Ultimately the floating point error occurs in:
((m % n) + n) % n
insideCesiumMath.mod
.The fix was to early-out if the input was already in the correct range.
Fixes #9312