Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rendering issues related to environmentState.renderTranslucentDepthForPick #9991

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jan 4, 2022

This PR has the changes in #9844 plus some of my own changes. Opening as a separate PR because the original branch was not recoverable.

@ebogo1 this should be good, but could you do a final review and merge?

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ebogo1
Copy link
Contributor

ebogo1 commented Jan 4, 2022

Thanks @lilleyse - these changes look good to me. I noticed a couple things:

  1. After rotating the camera, picked positions outside of the point cloud are undefined. After speaking offline, it's possible this is related to pickPosition isn't accurate when depthTestAgainstTerrain is false #8179
  2. The original PR mentioned issues with viewer.camera.switchToPerspectiveFrustum() and viewer.camera.switchToOrthographicFrustum() after these changes. I used the Sandcastle code from #9824 to double check this, and I was unable to reproduce any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants