-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WebP extension #448
Conversation
Make sure to add a test. Otherwise looks good. |
@lilleyse just did! I didn't want to @ mention you until I did 😄 |
Actually, would it make sense to wait on this until a glTF extension is in place? Only png and jpeg are officially supported. |
I think that makes sense. I could start working on putting together a draft. |
Absolutely please write the extension concurrent to this; if the extension is held up then merge this to a non-master branch. See KhronosGroup/glTF#1503. |
@OmarShehata Offline we talked about what changes gltf-pipeline would need once the extension is in place. Anywhere images are processed it will need to check for the WebP extension and process the WebP images too. A good way to do this is look at wherever |
I've expanded the scope of this PR. It should now correctly process glTF's with the proposed |
Superseded by #450 |
This PR adds support for the EXT_image_webp extension. It makes sure to take into account for the image defined in the extension if found when combining images into buffers.