-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic CESIUM_primitive_outline support #631
Conversation
Attached here is a ZIP that contains some stuff that may be useful for testing:
cesiumPrimitiveOutline-2023-04-15.zip EDIT: If all this looks OK, I'd add a basic test, analogous to https://github.com/javagl/gltf-pipeline/blob/3a5a71d5d2803831a477d35fa87b91f0fc6a8807/specs/lib/removeUnusedElementsSpec.js#L910 |
A random note: The README at https://github.com/CesiumGS/gltf-pipeline/blob/dc213115d2ca12bd5afae00770e48c019ac7d2d5/README.md#command-line-flags says
but the actual default seems to be 11, as of gltf-pipeline/lib/compressDracoMeshes.js Line 493 in dc21311
(I can fix that in this PR, if desired) |
|
Thank @javagl. The doc updates look good too. |
The
removeUnusedElements
family of functions considered the accessors that are used byCESIUM_primitive_outline
to be "unused", and removed them.This PR is a small fix that causes these accessors to be preserved, and the
CESIUM_primitive_outline.indices
to be updated (no, not the accessor contents, only that accessor index).This is implemented in a somewhat copy-and-paste-ish style: It uses the same approach that was used for other extensions. But one could consider to generalize the approach there: Having to support each extension manually like this does not scale indefinitely....
This might fix #630