Option for saving 'gltf.extras' #200
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lilleyse, I just submitted my CLA to cla@agi.com. |
|
Thanks again for contributing, @pairote! We received your CLA. |
|
can we get this merged? I would love to have this functionality. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
According to the glTF 2.0 specification,
extrasis one of the properties of the root object for a glTF asset. Its purpose is for storing application-specific data. See: https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#reference-gltfThis PR adds a new command line flag
--extrasPathfor specifying the path to a JSON file that contains an object for storing application-specific data. It also adds an optionextrasfor specifying the object when using obj2gltf as a library. The object will be saved to the top-level of the glTF.Although the type of
extrasisanywhich includes primitive types, the discussion on the glTF spec for primitive extras has resolved — extras should be objects as best practice, and primitive extras may be disallowed in the future. See: KhronosGroup/glTF#1120Best,