-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and extend tezos-caip2/10/122 + Tezos namespace #104
Update and extend tezos-caip2/10/122 + Tezos namespace #104
Conversation
Signed-off-by: jdsika <carlo.van-driesten@vdl.digital>
…os-caip122 Signed-off-by: jdsika <carlo.van-driesten@vdl.digital>
add tezos namespace prefix to cahin ID
Question: |
The answer to this could be that the namespace prefix tells what the main chain is and we need to define a criteria in the tezos namespace document on how to determine "social consensus" like e.g. "the longest chain in Bitcoin" |
add tezos namespace
Use correct hash function description
* define ghostnet and mainnet as aliases
* use mainnet and ghostnet as chain id aliases
* added Networks as chain ID aliases
* remove Qibing Li (@QibingLee) as user does not exist
* remove Qibing Li (@QibingLee) as user does not exist
this is truly a difficult problem, engineered with different combinations of technical and/or social mechanisms in each namespace! feel free to describe the tezos solution (non-normatively, and with links to the most-normative/most-canonical doc you can find in the tezosphere) in |
Can you point me to a document of a chain that has solved in the most elegant way? I actually think it is not solved in tezos (doing research ATM) Also is it allowed to define an alias for the chain ID as I did it? Update: I have described the Tezos solution in a paragraph. In addition I have created a ticket regarding a registry for aliases: |
* update integrity gurantees for chain IDs
* add tz4 addresses
* add reference to CAIP-104
Update data model
* use account_id instead of address
Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
@bumblefudge can you tell me what the rational was to not include the public key in the CAIP-122 data model but only the account id information? |
@royscheeren could you add a complete sample plain text message and a base64url-encoded byte representation as example in caip-122, please? |
Signed-off-by: Roy Scheeren <hi@royscheeren.com>
Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
Signed-off-by: Carlo van Driesten <carlo.van-driesten@vdl.digital>
Is the reason that looking at Ethereum the public key can be extracted from secp256k1 and the data model was taken from the EIP? |
Signed-off-by: jdsika <carlo.van-driesten@vdl.digital>
i'm not sure I understand the question entirely. In EVM, ECRecover is how you check a signature against an address (not knowing the pubkey per se, but being able to derive two of them from the address and check both against the signature). In other systems, like BTC and derivatives, different recovery mechanisms allow you to derive a public key from an address and a signature produced by its privkey. in systems like Solana or Polkadot where the address is (or is a simple transformation of) the public key, the derivation is simpler and does not require a signature. the logic of CAIP-122 is that these mechanics should be specified in the namespace's CAIP-10 profile, and left out-of-scope, since an account, rather than a public key, is what is being authenticated. does that help? |
Yes, it helped and that is what I meant to ask. I do not see the requirement to derive a public key in CAIP-10?
I think I will not put the public key in the data model of SIWX and make a section that explains on how to get in Tezos and that is the responsibility of the connection layer between app and wallet. |
Signed-off-by: jdsika <carlo.van-driesten@vdl.digital>
@bumblefudge I clarified the public key exchange. Feel free to start your review. Who should be the second necessary reviewer? |
Getting there! Just wordsmithing at this point, the content seems good |
Editorial pass for minor style guide issues and clarity
* revert alias to URN
* Refine the alias explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included @bumblefudge editorial review and discussion results
Ping @bumblefudge |
Sorry! missed the notif that you'd merged the last PR on your side. 🤝 |
feel free to tag me in any implementation threads out in the world, or if i can help on the tezos gitlab, i just updated my gitlab email so i should be taggable there as well (also @ bumblefudge) |
@bumblefudge I can finally make some time to finalize this work which has been started in #40 .
I think you can review the following documents and decide if this qualifies for a status "final":
I am not sure if the required specifications need to list the respective namespace derivative or the original specification (or both)?
I have addressed this comment here:
I will continue with your comments regarding the tezos-caip122