Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

evm CLI #46

Merged
merged 55 commits into from
Aug 6, 2021
Merged

evm CLI #46

merged 55 commits into from
Aug 6, 2021

Conversation

P1sar
Copy link
Member

@P1sar P1sar commented Jul 22, 2021

Todo:

mvp:

  • transfer commands from chainbridge-celo (urfave/cli -> spf13/cobra)
  • deploy bridge
  • deploy erc20
  • deploy erc20 handler
  • register resource
  • register erc20 as mintable/burnable
  • add erc20handler as erc20 minter
  • approve erc20
  • mint erc20
  • deposit erc20 => implemented but not working correctly
    ^ need to review parsing specific methods from ABI (method names + related contracts)
  • add test script (i.e. chainbridge-celo/cli_test.sh)
  • refactor to remove test alice privatekey
  • e2e test
  • test command local flags
  • test command global flags
  • ensure flag naming convention consistent across commands
    ^ maxim handling the flags in separate PR

refactor:

  • function to hold global flag value fetching for commands to reuse
  • function to combine ABI/BIN method inputs + invokes transaction (similar to deployContract)
    ^ kirill pushed update to resolve this; use Transact function from /chains/evm/calls/utils.go

post-mvp:

  • admin
  • erc721
  • bridge

Description

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@P1sar P1sar mentioned this pull request Jul 22, 2021
@waymobetta
Copy link
Contributor

In certain places resourceId flag is a string and in others it is a uint64. I’m just going to keep it consistent as a string

@lgtm-com
Copy link

lgtm-com bot commented Jul 25, 2021

This pull request introduces 1 alert when merging e7d8c63 into dd3876a - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2021

This pull request introduces 2 alerts when merging 2d3c56e into dd3876a - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types
  • 1 for Useless assignment to local variable

@P1sar P1sar requested a review from vezenovm July 27, 2021 11:39
@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2021

This pull request introduces 4 alerts when merging 1584e36 into dd3876a - view on LGTM.com

new alerts:

  • 3 for Useless assignment to local variable
  • 1 for Incorrect conversion between integer types

@P1sar P1sar changed the title initial commit for CLI evm CLI Aug 5, 2021
Co-authored-by: Kirill <pisarevkir@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2021

This pull request introduces 1 alert when merging aee24f4 into 6e06981 - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 5, 2021

This pull request introduces 1 alert when merging e95cb04 into 6e06981 - view on LGTM.com

new alerts:

  • 1 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging bc3b855 into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging f0490c9 into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging 5d1e79a into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging a9da6fd into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging 71b72e7 into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging f55a2ae into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging cf774af into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

@P1sar P1sar marked this pull request as ready for review August 6, 2021 20:13
@P1sar P1sar merged commit c0255ba into main Aug 6, 2021
@P1sar P1sar deleted the p1sar/evm-cli branch August 6, 2021 20:13
@lgtm-com
Copy link

lgtm-com bot commented Aug 6, 2021

This pull request introduces 2 alerts when merging cc61352 into 6e06981 - view on LGTM.com

new alerts:

  • 2 for Incorrect conversion between integer types

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants