chore: update example #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Jun 3, 2024
| import PeerId from "peer-id"; | ||
|
|
||
| const myPeerId: PeerId = ...; | ||
|
|
||
| const bootstrapEnrs: ENR[] = [...]; | ||
| const bootEnrs: ENR[] = [...]; |
There was a problem hiding this comment.
can you add an import for this type?
There was a problem hiding this comment.
we have a general issue with our readme examples also in the Lodestar repo, might wanna spend some time investigating ChainSafe/lodestar#6300. This would ensure the examples are runnable and detect issues due to code refactoring / dependency updates.
nflaig
reviewed
Jun 4, 2024
| import { Discv5Discovery, ENR } from "@chainsafe/discv5"; | ||
| import Libp2p from "libp2p"; | ||
| import {Discv5Discovery} from "@chainsafe/discv5"; | ||
| import {ENR, SignableENR} from "@chainsafe/enr"; |
There was a problem hiding this comment.
do we have to import these from enr package or does discv5 re-export? the later seems better devex to me
There was a problem hiding this comment.
I haven't seen them being re-exported. Maybe @wemeetagain knows better?
nflaig
approved these changes
Jun 11, 2024
|
Two follow-ups to this PR
Also @wemeetagain should probably give this a final ✔️ |
wemeetagain
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the
libp2pintegration example reflects the latest libp2p version.