-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI for proof test with cid #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tested on my local machine!
btw should we add /ui
in /package.json
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great!
@clearloop what is lerna used for? Did you set it up so that you can use any package locally without needing them to be published? |
yarn workspace already supported this feature, once you made https://classic.yarnpkg.com/lang/en/docs/workspaces/#toc-how-does-it-compare-to-lerna currently Lines 15 to 20 in 7efe143
also, we can use lerna to do the version control stuff for our javascript packages in the future
mb you can try to play with the version control stuff with lerna LOL, it's really a tough topic in javascript package management I think, and lerna is also hard to control in my past experience... and for the metadata part, you were right, we don't need to write types for filecoindot since metadata-v14 handled it perfectly, we haven't tag |
yarn workspace is what I've seen used the most indeed, and ppl, just like you mentioned were avoiding lerna as much as possible. |
This is a simple UI with relatively helpful messages if:
For now the wallet account is useless since there is nothing that needs to be signed.
test.mp4