Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trait RpcMethod for server, client, and schema #4067

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

aatifsyed
Copy link
Contributor

Summary of changes

Iteration on #4033.

This approach obviates the need to define client operations separately:
https://github.com/ChainSafe/forest/blob/d0b490e7889157c668c1e3f4f96416fb093cf1c9/src/rpc_client/chain_ops.rs

In the limit, src/rpc_client can be deleted.

Obsoletes

Tracking

Follow up work

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@aatifsyed aatifsyed requested a review from a team as a code owner March 15, 2024 16:27
@aatifsyed aatifsyed requested review from lemmih and LesnyRumcajs and removed request for a team March 15, 2024 16:27
@aatifsyed aatifsyed mentioned this pull request Mar 15, 2024
@aatifsyed aatifsyed added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@lemmih lemmih added this pull request to the merge queue Mar 18, 2024
@lemmih
Copy link
Contributor

lemmih commented Mar 18, 2024

Auto merge failed due to network error when connecting to ghcr.

Merged via the queue into main with commit d753041 Mar 18, 2024
28 checks passed
@lemmih lemmih deleted the aatifsyed/trait-rpc-method branch March 18, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants