Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Filecoin.EthGetBlockByNumber #4138

Merged
merged 110 commits into from
Apr 19, 2024
Merged

feat: implement Filecoin.EthGetBlockByNumber #4138

merged 110 commits into from
Apr 19, 2024

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Apr 3, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • Add Filecoin.EthGetBlockByNumber RPC method
./forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2024-04-03_height_1494010.forest.car.zst --filter EthGetBlockByNumber
| RPC Method                       | Forest | Lotus |
|----------------------------------|--------|-------|
| Filecoin.EthGetBlockByNumber (2) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4183

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

elmattic added 30 commits April 3, 2024 13:33
@elmattic
Add EthGetBlockByNumber method (wip)
0c24d27
@elmattic
Merge branch 'main' into elmattic/eth-get-block-by-number
7b1c5e0
@elmattic
Fix EthBlock construction
ca7374d
@elmattic
Fix gas limit
32c52ec
@elmattic
Refactor using first method
7da6a77
@elmattic
Add full bloom filter
f94b0ee
@elmattic
Add empty uncles hash
a282565
@elmattic
Start to add support for txs
ee5cae0
@elmattic
Add support for eth message (wip)
c3ef03a
@elmattic
Add from_filecoin_address impl
a7f5b91
@elmattic
Add eth_tx_args_from_unsigned_eth_message impl
be215c8
@elmattic
Add eth_tx_from_native_message impl (wip)
256627f
@elmattic
Add support for to/from addr to Tx
d18ca39
@elmattic
Refactor using trait
ea58cc7
@elmattic
Add input to Tx (wip)
f7a2bf5
@elmattic
Use chainId from chain config
1bf353b
@elmattic
Fix eth tx
d3f782b
@elmattic
Add native message support (wip)
900ea42
@elmattic
Add unit test and fix slice copy and formatting issues
9f28f80
@elmattic
Merge branch 'main' into elmattic/eth-get-block-by-number
792d7c2
@elmattic
Fix the To address for unsigned eth tx
c8cb12a
@elmattic
Minor refactor
eae9477
@elmattic
Add unit test for tx rpl encoding
c1e1281
@elmattic
Add missing test
640b6f0
@elmattic
Merge branch 'main' into elmattic/eth-get-block-by-number
a9637d2
@elmattic
Start implementation of TxArgs rlp encoding
6028b65
@elmattic
Fix sig data in unit test
37cec83
@elmattic
Fix sig beeing inline during rlp encoding
f5032a3
@elmattic
Fix input member that was starting with too much bytes
2249a81
@elmattic
Fix access list rlp encoding
02887c6
@elmattic elmattic requested review from lemmih and LesnyRumcajs April 17, 2024 11:02
lemmih
lemmih requested changes Apr 18, 2024
View reviewed changes
src/shim/executor.rs Outdated Show resolved Hide resolved
src/rpc/methods/chain.rs Outdated Show resolved Hide resolved
src/rpc/methods/eth.rs Outdated Show resolved Hide resolved
lemmih
lemmih reviewed Apr 19, 2024
View reviewed changes
src/shim/executor.rs Outdated Show resolved Hide resolved
@elmattic @lemmih
Update src/shim/executor.rs
780664e 
Co-authored-by: David Himmelstrup <david.himmelstrup@chainsafe.io>
lemmih
lemmih approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of moving parts.

@LesnyRumcajs
Copy link
Member

No green checkmark, no review!

@ruseinov ruseinov self-requested a review April 19, 2024 15:04
@ruseinov ruseinov added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 3c05d1a Apr 19, 2024
27 checks passed
@ruseinov ruseinov deleted the elmattic/eth-get-block-by-number branch April 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@ruseinov ruseinov ruseinov approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

@LesnyRumcajs LesnyRumcajs Awaiting requested review from LesnyRumcajs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filecoin.EthGetBlockByNumber
4 participants
@elmattic @LesnyRumcajs @ruseinov @lemmih