feat(rpc): implement Filecoin.MsigGetVested and Filecoin.MsigGetVestingSchedule #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-shashank
requested review from
ruseinov and
LesnyRumcajs
and removed request for
a team
sudo-shashank
changed the title
lemmih
approved these changes
May 10, 2024
src/rpc/methods/msig.rs
Outdated
Comment on lines
146
to
177
| let msig_vesting = match &ms { | ||
| multisig::State::V8(st) => MsigVesting { | ||
| initial_balance: st.initial_balance.atto().clone(), | ||
| start_epoch: st.start_epoch, | ||
| unlock_duration: st.unlock_duration, | ||
| }, | ||
| multisig::State::V9(st) => MsigVesting { | ||
| initial_balance: st.initial_balance.atto().clone(), | ||
| start_epoch: st.start_epoch, | ||
| unlock_duration: st.unlock_duration, | ||
| }, | ||
| multisig::State::V10(st) => MsigVesting { | ||
| initial_balance: st.initial_balance.atto().clone(), | ||
| start_epoch: st.start_epoch, | ||
| unlock_duration: st.unlock_duration, | ||
| }, | ||
| multisig::State::V11(st) => MsigVesting { | ||
| initial_balance: st.initial_balance.atto().clone(), | ||
| start_epoch: st.start_epoch, | ||
| unlock_duration: st.unlock_duration, | ||
| }, | ||
| multisig::State::V12(st) => MsigVesting { | ||
| initial_balance: st.initial_balance.atto().clone(), | ||
| start_epoch: st.start_epoch, | ||
| unlock_duration: st.unlock_duration, | ||
| }, | ||
| multisig::State::V13(st) => MsigVesting { | ||
| initial_balance: st.initial_balance.atto().clone(), | ||
| start_epoch: st.start_epoch, | ||
| unlock_duration: st.unlock_duration, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Is this a good place for this? @hanabi1224 implemented it src/shim/actors/market/balance_table.rs, which allows re-usability.
There was a problem hiding this comment.
As far as I remember we usually have this state matching code in fil-actor-states, I guess we should either keep it that way or move all of that logic out to shim. It's much better to have all the similar logic in predictable places, otherwise it's hard to navigate.
There was a problem hiding this comment.
Ah, we have a custom struct here. Then perhaps it belongs to forest.
The stuff I was talking about before:
There was a problem hiding this comment.
moved inside src/shim/actors/multisig
ruseinov
approved these changes
May 10, 2024
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Filecoin.MsigGetVestedandFilecoin.MsigGetVestingScheduleRPC methodFilecoin.MsigGetAvailableBalanceandFilecoin.MsigGetPending(10) fromstate.rstomsig.rsReference issue to close (if applicable)
contributes to #4164
Other information and links
Change checklist