Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): implement Filecoin.EthGetMessageCidByTransactionHash #4402

Merged

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Jun 7, 2024

Summary of changes

Changes introduced in this pull request:

  • Implement RPC method Filecoin.EthGetMessageCidByTransactionHash
./forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2024-06-17_height_1710369.forest.car.zst --filter EthGetMessageCidByTransactionHash
| RPC Method                                      | Forest | Lotus |
|-------------------------------------------------|--------|-------|
| Filecoin.EthGetMessageCidByTransactionHash (33) | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4368

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic changed the base branch from main to elmattic/eth-mappings June 7, 2024 12:30
@elmattic elmattic mentioned this pull request Jun 12, 2024
4 tasks
@elmattic elmattic marked this pull request as ready for review July 1, 2024 09:17
@elmattic elmattic requested a review from a team as a code owner July 1, 2024 09:17
@elmattic elmattic requested review from LesnyRumcajs and sudo-shashank and removed request for a team July 1, 2024 09:17
scripts/tests/calibnet_eth_mapping_check.sh Outdated Show resolved Hide resolved
scripts/tests/calibnet_eth_mapping_check.sh Outdated Show resolved Hide resolved
for ((i=0; i<=NUM_TIPSETS; i++)); do
EPOCH_HEX=$(printf "0x%x" $EPOCH)
#echo "$EPOCH_HEX"
JSON=$(curl -s -X POST 'http://127.0.0.1:2345/rpc/v1' -H 'Content-Type: application/json' --data "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"Filecoin.EthGetBlockByNumber\",\"params\":[\"$EPOCH_HEX\", false]}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to avoid this escaping hell.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this reduces eye fatigue for you.

scripts/tests/harness.sh Outdated Show resolved Hide resolved
src/chain_sync/tipset_syncer.rs Show resolved Hide resolved
src/rpc/methods/eth.rs Show resolved Hide resolved
name: Calibnet eth mapping check
runs-on: ubuntu-latest
steps:
- run: lscpu
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean lscpu?

@elmattic elmattic added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 60e3a4e Jul 3, 2024
28 checks passed
@elmattic elmattic deleted the elmattic/elmattic/eth-get-message-cid-by-transaction-hash-2 branch July 3, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filecoin.EthGetMessageCidByTransactionHash
4 participants