Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developer notes on Lotus Chain Index #4778

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Add developer notes on Lotus Chain Index #4778

merged 3 commits into from
Sep 19, 2024

Conversation

elmattic
Copy link
Contributor

@elmattic elmattic commented Sep 19, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #4765

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review September 19, 2024 11:20
@elmattic elmattic requested a review from a team as a code owner September 19, 2024 11:20
@elmattic elmattic requested review from ruseinov and lemmih and removed request for a team September 19, 2024 11:20
ruseinov
ruseinov reviewed Sep 19, 2024
View reviewed changes
documentation/src/developer_documentation/chain_index_spike.md
1. Use a graph database or a graph query language:

- **Neo4j**
- **GraphQL**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personal experience: GQL is a pain to work with.

ruseinov
ruseinov approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid research!

having a 40+GB SQL database seems like an overkill here indeed. Perhaps figuring out the use-cases we want to cater for is the best way to choose a path here.

@elmattic elmattic added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 6383ea5 Sep 19, 2024
33 checks passed
@elmattic elmattic deleted the elmattic/chain_index_spike.md branch September 19, 2024 11:43
@LesnyRumcajs
Copy link
Member

Post-merge review: I like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@ruseinov ruseinov ruseinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chain Events spike
4 participants
@elmattic @LesnyRumcajs @ruseinov @lemmih