Func for generating mini secret for mnemonic #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stringnick seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
noot
reviewed
Mar 17, 2022
bip39.go
Outdated
| @@ -13,6 +13,21 @@ import ( | |||
| // WARNING: Non-standard BIP39 Implementation | |||
| // Designed for compatibility with the Rust substrate-bip39 library | |||
|
|
|||
| // GenerateMiniSecretKeyMnemonic returns mnemonic for func MiniSecretKeyFromMnemonic | |||
| func GenerateMiniSecretKeyMnemonic() (string, error) { | |||
There was a problem hiding this comment.
can you rename this to GenerateMnemonic?
noot
reviewed
Mar 17, 2022
bip39.go
Outdated
| @@ -13,6 +13,21 @@ import ( | |||
| // WARNING: Non-standard BIP39 Implementation | |||
| // Designed for compatibility with the Rust substrate-bip39 library | |||
|
|
|||
| // GenerateMiniSecretKeyMnemonic returns mnemonic for func MiniSecretKeyFromMnemonic | |||
| func GenerateMiniSecretKeyMnemonic() (string, error) { | |||
| entropy, err := bip39.NewEntropy(256) | |||
There was a problem hiding this comment.
can you change 256 to a constant? eg const entropySize = 256 at the top of the function? also any particular reason for 256?
noot
reviewed
Mar 17, 2022
rn generate mnemonic func name
noot
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.