chore: fix linting

dot/state/block.go

@@ -959,7 +959,7 @@ func (bs *BlockState) closestAncestorWithInstance(blockHash common.Hash) (instan
 		// the first ancestor will have the highest number which means it is
 		// the closest ancestor with an instance
 		if isDescendant {
-			return bs.bt.RuntimesMappingGet(header.Hash()), nil
+			return bs.bt.GetBlockRuntimeOrFail(header.Hash())
 		}
 	}
 

lib/blocktree/blocktree.go

@@ -531,7 +531,8 @@ func (bt *BlockTree) StoreRuntime(hash common.Hash, instance Runtime) {
 	bt.runtimes.set(hash, instance)
 }
 
-// GetBlockRuntime returns block runtime for corresponding block hash.
+// GetBlockRuntime returns block runtime for corresponding block hash, if there is no instance for
+// the given block hash it will lookup an instance of an ancestor and returns it.
 func (bt *BlockTree) GetBlockRuntime(hash common.Hash) (Runtime, error) {
 	// if the current node contains a runtime entry in the runtime mapping
 	// then we early return the instance, otherwise we will lookup for the
@@ -562,17 +563,18 @@ func (bt *BlockTree) GetBlockRuntime(hash common.Hash) (Runtime, error) {
 	return nil, ErrRuntimeNotFound
 }
 
+// GetInMemoryRuntimesBlockHashes returns all the runtimes mapping keys
 func (bt *BlockTree) GetInMemoryRuntimesBlockHashes() []common.Hash {
 	return bt.runtimes.hashes()
 }
 
-func (bt *BlockTree) RuntimesMappingGet(hash common.Hash) (instance Runtime) {
-	bt.runtimesLock.RLock()
-	defer bt.runtimesLock.RUnlock()
-
-	if bt.runtimes == nil {
-		return nil
+// GetBlockRuntime returns block runtime for corresponding block hash. if there is no instance
+// fot the given block hash it returns ErrRuntimeNotFound
+func (bt *BlockTree) GetBlockRuntimeOrFail(hash common.Hash) (instance Runtime, err error) {
+	instance = bt.runtimes.get(hash)
+	if instance == nil {
+		return nil, ErrRuntimeNotFound
 	}
 
-	return bt.runtimes.get(hash)
+	return instance, nil
 }