lib/runtime: implement ext_submit_transaction #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
reviewed
Oct 5, 2020
lib/runtime/test_helpers.go
Outdated
| @@ -307,3 +309,11 @@ func (trn testRuntimeNetwork) NetworkState() common.NetworkState { | |||
| Multiaddrs: testAddrs, | |||
| } | |||
| } | |||
|
|
|||
| type mockTransaction struct { | |||
There was a problem hiding this comment.
rename to mockTransactionState?
noot
reviewed
Oct 5, 2020
lib/runtime/imports_old.go
Outdated
|
|
||
| // validate the transaction | ||
| txv := transaction.NewValidity(0, [][]byte{{}}, [][]byte{{}}, 0, false) | ||
| // todo determine how to validate transaction here, calling runtimeAPI.ValidateTransaction? |
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ext_submit_transactionfunctionTests
Checklist
Issues