Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/runtime: implement ext_crypto_secp256k1_ecdsa_recover_compressed_version_1 #1442

Merged
merged 29 commits into from
Mar 9, 2021
Merged

lib/runtime: implement ext_crypto_secp256k1_ecdsa_recover_compressed_version_1 #1442

merged 29 commits into from
Mar 9, 2021

Conversation

noot
Copy link
Contributor

@noot noot commented Mar 7, 2021 •
edited
Loading

Changes

  • implement ext_crypto_secp256k1_ecdsa_recover_compressed_version_1
  • comment out batch signature verification for now since it fails to verify, see issue fix ext_crypto_sr25519_verify_version_1 #1393
  • cleanup some network logs, disconnect if handshake is invalid (on polkadot it seems a lot of nodes try to connect to us that are actually on a different network)

Tests

go test ./lib/crypto/secp256k1

Checklist

  • I have read CODE_OF_CONDUCT and CONTRIBUTING
  • I have provided as much information as possible and necessary
  • I have reviewed my own pull request before requesting a review
  • All integration tests and required coverage checks are passing

Issues

noot added 23 commits March 5, 2021 14:36
@noot noot self-assigned this Mar 7, 2021
Base automatically changed from noot/deprecate-legacy-runtime to development March 8, 2021 17:50
@noot noot marked this pull request as ready for review March 8, 2021 19:40
@noot noot merged commit f12a334 into development Mar 9, 2021
@noot noot deleted the noot/sync-polkadot branch March 9, 2021 19:20
github-actions bot pushed a commit that referenced this pull request Mar 9, 2021
@noot
Deploy docs from f12a334
d0ad7ad 
noot: feat: lib/runtime: implement ext_crypto_secp256k1_ecdsa_recover_compressed_version_1 (#1442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arijitAD arijitAD arijitAD approved these changes

@RyRy79261 RyRy79261 RyRy79261 approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

Assignees

@noot noot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noot @arijitAD @RyRy79261