-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lib/trie: fix trie.NextKey #1449
Conversation
I have added a test for the next trie key which seems to fail. Also, the test seems to fail if I add an empty string to the test case. Not sure if it's a valid scenario. |
@arijitAD I made an update so that there are no duplicate keys in the test list and looks like it's good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Nice work 👌
noot: fix: lib/trie: fix trie.NextKey (#1449)
Changes
trie.NextKey
to work properly (and handle keys not in the trie)trie.NextKey
in runtime storageTests
Checklist
Issues