chore(runtime): move InstanceConfig to lib/runtime/wasmer
#2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
force-pushed
the
qdm12/runtime/move-config-wasmer
branch
from
997e201
to
c28ae53
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2751 +/- ##
===============================================
+ Coverage 62.78% 62.94% +0.15%
===============================================
Files 213 213
Lines 27081 27081
===============================================
+ Hits 17003 17045 +42
+ Misses 8527 8486 -41
+ Partials 1551 1550 -1 |
EclesioMeloJunior
approved these changes
Aug 15, 2022
qdm12
force-pushed
the
qdm12/runtime/move-config-wasmer
branch
from
c28ae53
to
796fb65
Compare
jimjbrettj
approved these changes
Aug 15, 2022
qdm12
force-pushed
the
qdm12/runtime/move-config-wasmer
branch
2 times, most recently
from
28edafa
to
6e57e0f
Compare
qdm12
force-pushed
the
qdm12/runtime/move-config-wasmer
branch
from
6e57e0f
to
f0120a7
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Move
InstanceConfigfromlib/runtimetoConfiginlib/runtime/wasmerThis is so private fields can be added for test-only in the wasmer package (blocks #2747)
Tests
Issues
#2418
Primary Reviewer
@timwu20