chore(dot/peerset): remove the time.Sleep() dependency. #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #issue-2520
axaysagathiya
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
qdm12
as code owners
axaysagathiya
changed the title
qdm12
suggested changes
Aug 25, 2022
Comment on lines
+85
to
+90
| waitGroup.Add(1) | ||
| go func() { | ||
| handler.AddReservedPeer(testSetID, peerID) | ||
| waitGroup.Done() | ||
| }() | ||
| waitGroup.Wait() |
There was a problem hiding this comment.
This doesn't do anything (same as just handler.AddReservedPeer(testSetID, peerID))
I think we want to wait for a fire-and-forget goroutine launched within AddReservedPeer, so that would require a refactor of the production code of the method AddReservedPeer. Just a wild guess though, I haven't really digged into that method either.
Same comment for the other changes.
Parallel programming is hard too, so take it easy 😉
|
Converting this back to draft until changes are made. Feel free to un-draft once it's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
removed
time.Sleep()dependency by usingsync.WaitGroupin dot/peerset/peerset_test.goTests
go test github.com/ChainSafe/gossamer/dot/peersetIssues
#2520
Primary Reviewer
@timwu20