Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/grandpa): on verifying block justification, compare given block hash with finalised hash #3081

Merged
merged 42 commits into from
Feb 10, 2023
Merged

fix(lib/grandpa): on verifying block justification, compare given block hash with finalised hash #3081

merged 42 commits into from
Feb 10, 2023

Commits on Jan 23, 2023

  1. Fixing descendant search 

    If blocktree fails to get highest finalised hash (which is stored in
memory), load it from disk.

Fixes #3053
    @kishansagathiya
    kishansagathiya committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    a86dcb3 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @kishansagathiya
    kishansagathiya committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b20a8e2 View commit details
    Browse the repository at this point in the history

  3. parent -> hash

    @kishansagathiya
    kishansagathiya committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    9e7be4d View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. different approach for getting descendants

    @kishansagathiya
    kishansagathiya committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d0aa5f8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. different approach for getting descendants

    @kishansagathiya
    kishansagathiya committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    32db55a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into kishan/fix/syncing

    @kishansagathiya
    kishansagathiya committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    532db0e View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. fixed the use of bs.GetAllDescendants

    @kishansagathiya
    kishansagathiya committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0f76155 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into kishan/fix/syncing

    @kishansagathiya
    kishansagathiya committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b7f0a8a View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. temp

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    03f1ecb View commit details
    Browse the repository at this point in the history

  2. temp

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3529a36 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kishan/fix/syncing' into kishan/fix/getting-runtime-ins… 

    …tance
    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    66fb9d1 View commit details
    Browse the repository at this point in the history

  4. temo

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    57f5eb8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'kishan/fix/syncing' into kishan/fix/getting-runtime-ins… 

    …tance
    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1aa8c74 View commit details
    Browse the repository at this point in the history

  6. check hash on verifying block justification 

    So far, while verifying block justification in grandpa, we were just
checking if we already know a finalised block that has the same set id and
round as the block in question.

we should check if the finalised block that we know already and the
block that we are verifying are not the same and not throw error in this
case.

Fixes #3061
    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    90a2992 View commit details
    Browse the repository at this point in the history

  7. some cleanup

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    a8d2af7 View commit details
    Browse the repository at this point in the history

  8. more clean up

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7d775fa View commit details
    Browse the repository at this point in the history

  9. more cleanup

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0f625fd View commit details
    Browse the repository at this point in the history

  10. more cleanup

    @kishansagathiya
    kishansagathiya committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    d0ce09a View commit details
    Browse the repository at this point in the history

  11. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya authored Jan 30, 2023
    Configuration menu
    Copy the full SHA
    533a1cf View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. clean up

    @kishansagathiya
    kishansagathiya committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    75fc709 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'kishan/fix/getting-runtime-instance' of github.com:Chai… 

    …nSafe/gossamer into kishan/fix/getting-runtime-instance
    @kishansagathiya
    kishansagathiya committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    b7490a9 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. use get finalised hash

    @kishansagathiya
    kishansagathiya committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    664136c View commit details
    Browse the repository at this point in the history

  2. added test

    @kishansagathiya
    kishansagathiya committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    94af433 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    919b1ce View commit details
    Browse the repository at this point in the history

  4. fix lint

    @kishansagathiya
    kishansagathiya committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1c9d9e2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    6017fdd View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. remove returning justification from VerifyJustification

    @kishansagathiya
    kishansagathiya committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    fb0b5b3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya authored Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5577798 View commit details
    Browse the repository at this point in the history

  3. fixing a few more things

    @kishansagathiya
    kishansagathiya committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    fb5c8b7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'kishan/fix/getting-runtime-instance' of github.com:Chai… 

    …nSafe/gossamer into kishan/fix/getting-runtime-instance
    @kishansagathiya
    kishansagathiya committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    99c9d4b View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    df39d57 View commit details
    Browse the repository at this point in the history

  2. fixing a test

    @kishansagathiya
    kishansagathiya committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    25134e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. no need to continue in case of storedFinalisedHash == hash

    @kishansagathiya
    kishansagathiya committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    df0f311 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9df1a6b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    feb0d43 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    94befd7 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. fix tests, removed some t.Parallel

    @kishansagathiya
    kishansagathiya committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3c10fe3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'kishan/fix/getting-runtime-instance' of github.com:Chai… 

    …nSafe/gossamer into kishan/fix/getting-runtime-instance
    @kishansagathiya
    kishansagathiya committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c1daf15 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ca43b2a View commit details
    Browse the repository at this point in the history

  4. fix lint`

    @kishansagathiya
    kishansagathiya committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c4e9108 View commit details
    Browse the repository at this point in the history

  5. try without t.Parallel

    @kishansagathiya
    kishansagathiya committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e11ba97 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Merge branch 'development' into kishan/fix/getting-runtime-instance

    @kishansagathiya
    kishansagathiya committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    aad958b View commit details
    Browse the repository at this point in the history