Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib/babe): Add context and additional assertion to TestBuildBlock_ok #3101

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix(lib/babe): Add context and additional assertion to TestBuildBlock_ok #3101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7caa23
clean func and add context to testing body in TestBuildBlock_ok
jimjbrettj Feb 8, 2023
92f0d76
feedback
jimjbrettj Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/babe/build_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ func TestSeal(t *testing.T) {
require.True(t, ok, "could not verify seal")
}

// TODO see if there can be better assertions on block body #3060
// Are extrinsics correct, what are the extrinsics now that there are 2 instead of 1, is one the same?
// Does order matter?
func TestBuildBlock_ok(t *testing.T) {
genesis, genesisTrie, genesisHeader := newWestendDevGenesisWithTrieAndHeader(t)
babeService := createTestService(t, ServiceConfig{}, genesis, genesisTrie, genesisHeader)
Expand All @@ -66,15 +63,16 @@ func TestBuildBlock_ok(t *testing.T) {
rt, err := babeService.blockState.GetRuntime(bestBlockHash)
require.NoError(t, err)

epochData, err := babeService.initiateEpoch(testEpochIndex)
testEpochData, err := babeService.initiateEpoch(testEpochIndex)
jimjbrettj marked this conversation as resolved.
Show resolved Hide resolved
require.NoError(t, err)

slot := getSlot(t, rt, time.Now())
ext := runtime.NewTestExtrinsic(t, rt, parentHash, parentHash, 0, signature.TestKeyringPairAlice,
extrinsic := runtime.NewTestExtrinsic(t, rt, parentHash, parentHash, 0, signature.TestKeyringPairAlice,
"System.remark", []byte{0xab, 0xcd})
block := createTestBlockWithSlot(t, babeService, emptyHeader, [][]byte{common.MustHexToBytes(ext)},
testEpochIndex, epochData, slot)
block := createTestBlockWithSlot(t, babeService, emptyHeader, [][]byte{common.MustHexToBytes(extrinsic)},
testEpochIndex, testEpochData, slot)

const expectedSecondExtrinsic = "0x042d000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000" //nolint:lll
expectedBlockHeader := &types.Header{
ParentHash: emptyHeader.Hash(),
Number: 1,
Expand All @@ -89,6 +87,10 @@ func TestBuildBlock_ok(t *testing.T) {
// confirm block body is correct
extsBytes := types.ExtrinsicsArrayToBytesArray(block.Body)
require.Equal(t, 2, len(extsBytes))
// The first extrinsic is based on timestamp so is not consistent, but since the second is based on
// Parachn0 and Newheads inherents this can be asserted against. This works for now since we don't support real
// parachain data in these inherents currently, but when we do this will need to be updated
require.Equal(t, expectedSecondExtrinsic, common.BytesToHex(extsBytes[1]))
}

func TestApplyExtrinsicAfterFirstBlockFinalized(t *testing.T) {
Expand Down