chore: remove peer-info usage #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
from
6b00355
to
6004b10
Compare
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
from
6004b10
to
ed2730f
Compare
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 82.75% 84.38% +1.62%
==========================================
Files 8 8
Lines 493 493
==========================================
+ Hits 408 416 +8
+ Misses 85 77 -8
Continue to review full report at Codecov.
|
BREAKING CHANGE: using new topology api with peer-id instead of peer-info and new pubsub internal peer data structure
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
from
ed2730f
to
602ccaa
Compare
|
Note: This should be released with a beta tag until we bubble everything up for
|
jacobheun
previously approved these changes
Apr 23, 2020
wemeetagain
approved these changes
Apr 23, 2020
|
Released v0.4.0 w beta tag |
fryorcraken
pushed a commit
to fryorcraken/js-libp2p-gossipsub
that referenced
this pull request
Aug 2, 2022
All uses of node Buffers have been replaced with Uint8Arrays BREAKING CHANGES: - The `.data`, `.from` and `.seq` properties of messages used to be node Buffers, now they are Uint8Arrays - All deps of this module now use Uint8Arrays instead of Buffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR removes thepeer-infousage on pubsub internal peer data structure. Moreover, this uses the new topology API, which also usespeer-idinstead ofpeer-infoBREAKING CHANGE: using new topology api with peer-id instead of peer-info and new pubsub internal peer data structure
Needs: