This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
chore: remove peer-info usage #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
from
2d1d46c
to
c79c205
Compare
This was referenced Apr 7, 2020
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
3 times, most recently
from
87939c7
to
60f521b
Compare
BREAKING CHANGE: pubsub internal peer does not have info propery anymore and use the new topology api with peer-id instead of peer-info
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
from
60f521b
to
21a63cb
Compare
jacobheun
suggested changes
Apr 21, 2020
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
chore/remove-peer-info-usage
branch
from
74c7422
to
7aae306
Compare
jacobheun
approved these changes
Apr 22, 2020
|
Yap, totally missed that! Just pushed the change of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of deprecating
peer-infoas described on libp2p/js-libp2p#589, this PR removes thepeer-infousage on pubsub internal peer data structure. Moreover, this uses the new topology API, which also usespeer-idinstead ofpeer-infoThis changes have impact on pubsub implementations.
BREAKING CHANGE: pubsub internal peer does not have info propery anymore and use the new topology api with peer-id instead of peer-info
Needs: