Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to include js-libp2p-connection-manager #6

Closed
Mikerah opened this issue Jan 14, 2019 · 1 comment
Closed

Refactor to include js-libp2p-connection-manager #6

Mikerah opened this issue Jan 14, 2019 · 1 comment

Comments

@Mikerah
Copy link
Contributor

Mikerah commented Jan 14, 2019

After asking about tagging peers on twitter, I was redirected to 2 issues related to the connection manager functionality in go-libp2p (1 and 2). These issues brought to my attention the js equivalent of the go connection manager, js-libp2p-connection-manager. This module manages connections to peers. However, it is lacking some of the functionality that the Go connection manager has.

Currently, I have copied over the peer class from the js-libp2p-floodsub as a temporary measure. However, I would have to manually add a lot of the functionality and I don't think it is worth the extra effort. My current thoughts are either to use js-libp2p-connection-manager as a super class and add the needed functionality (tagging,etc) and later on make a PR to the js-libp2p-connection-manager. Or make a PR to the js-libp2p-connection-manager to include some of this functionality before using it in our codebase.

@Mikerah
Copy link
Contributor Author

Mikerah commented May 21, 2019

closing for now...

@Mikerah Mikerah closed this as completed May 21, 2019
fryorcraken pushed a commit to fryorcraken/js-libp2p-gossipsub that referenced this issue Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant