-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps and remove protons #153
Conversation
aec5b0f
to
615b7d0
Compare
@hugomrdias I am having issues with mocha in playwright similar to hugomrdias/playwright-test#52 Are you aware of any regression? |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
===========================================
- Coverage 92.00% 72.29% -19.71%
===========================================
Files 2 2
Lines 25 1776 +1751
Branches 0 146 +146
===========================================
+ Hits 23 1284 +1261
- Misses 2 492 +490
Continue to review full report at Codecov.
|
615b7d0
to
1b14088
Compare
3097df1
to
dd8f462
Compare
We need to update gossipsub build step to rely on aegir. We can use noise as an example. I don't want to add more scope to this PR, so I will create an issue to track this change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, lots of ?
+ |null
again but I guess that's reasonable for now, can improve later
(also pending dev dep)
5527b4f
to
22a63ef
Compare
|
a6571c3
to
b831d2a
Compare
This PR is having some CI troubes, as it has some old hanging jobs. Either way, this is ready for review and pending the final release of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
@vasco-santos the
because the generated files are missing:
|
bah, not generating because the file is commited. But it needs to be moved to src on ts compile. I will change it in a sec |
f693515
to
954fa45
Compare
@achingbrain done, can you retry? |
@vasco-santos Much better, thanks! |
53bcefd
to
a6de21e
Compare
Updating all the dependencies and removing protons in favour of protobufjs for smaller bundles and avoiding bundle problems with web-encoding. This follows the work that is in progress in libp2p to use protobufjs everywhere. As a bonus, we can create type definitions automatically.
rpc.d.ts
andrpc.js
were generated by protobufjs CLI based on the proto file. Scripts for generating/updating them were also addedNeeds: