-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add stream option to limit inbound message size #349
Conversation
96cd112
to
8f461ca
Compare
Codecov ReportBase: 83.22% // Head: 83.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 83.22% 83.58% +0.36%
==========================================
Files 47 47
Lines 11713 11771 +58
Branches 1258 1267 +9
==========================================
+ Hits 9748 9839 +91
+ Misses 1965 1932 -33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
afa37c0
to
e12cc56
Compare
e12cc56
to
9ddb916
Compare
I think i will need to fix the tests since the pubsub reference has changed, let me update and push |
9ddb916
to
5d6bcc8
Compare
@dapplion ready for merge! |
If the size is not provided
decode
fromit-length-prefixed
lib applies the ~4mb limit by default:From npm docs:
bellatrix message sizes could be 10MB so this limit needs to be exposed via options so they can be set by lodestar