Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: initial implementation #2

Merged
merged 35 commits into from
Sep 7, 2022
Merged

feat: initial implementation #2

merged 35 commits into from
Sep 7, 2022

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain commented Jun 7, 2022 •
edited
Loading

TODO:

  • test window update functionality
  • add features implied by the config object
  • address open TODOs
  • add a README
  • update it-pushable
  • update interfaces
  • better metrics
  • interop testing with go

@wemeetagain wemeetagain mentioned this pull request Jun 7, 2022
Closed
@wemeetagain wemeetagain changed the title Initial implementation feat: initial implementation Jun 9, 2022
@wemeetagain wemeetagain marked this pull request as ready for review June 16, 2022 22:53
@wemeetagain wemeetagain requested review from a team and achingbrain as code owners June 16, 2022 22:53
mpetrunic
mpetrunic reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking sleek

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/config.ts Outdated Show resolved Hide resolved
src/config.ts Show resolved Hide resolved
src/decode.ts Show resolved Hide resolved
twoeths
twoeths reviewed Jun 18, 2022
View reviewed changes
src/decode.ts Outdated Show resolved Hide resolved
twoeths
twoeths reviewed Jun 18, 2022
View reviewed changes
src/decode.ts Show resolved Hide resolved
@wemeetagain wemeetagain mentioned this pull request Jun 26, 2023
Closed
dapplion
dapplion reviewed Jul 5, 2022
View reviewed changes
test/bench/codec.bench.ts Outdated Show resolved Hide resolved
dapplion
dapplion reviewed Jul 5, 2022
View reviewed changes
test/bench/codec.bench.ts Outdated Show resolved Hide resolved
@wemeetagain
Copy link
Member Author

Interop testing is blocked by libp2p/js-libp2p#1305 and libp2p/js-libp2p-mplex#211

@dapplion
Copy link

dapplion commented Sep 7, 2022

Ok from me to merge 👍 no point on sitting on this for longer. Fixes can be done after the fact

@wemeetagain
Copy link
Member Author

Ok merging this and will cut an initial release. When we have more real-world testing done we can bump to 1.0.0

@wemeetagain wemeetagain merged commit 1cd3d4e into master Sep 7, 2022
@wemeetagain wemeetagain deleted the feat/initial-implementation branch September 7, 2022 17:07
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion left review comments

@twoeths twoeths twoeths left review comments

@mpetrunic mpetrunic mpetrunic left review comments

@achingbrain achingbrain Awaiting requested review from achingbrain achingbrain is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wemeetagain @dapplion @mpetrunic @twoeths