-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support eventstream example (bls_to_execution_change) from recent beacon API test suite #6167
Comments
Updating test data here should fix this lodestar/packages/api/test/unit/beacon/testData/events.ts Lines 52 to 57 in 53378e1
|
Updating the test data doesn't entirely fix the test. Namely, It's not yet clear what the best fix would be. |
Let's just make the spec example address all lowercase? |
Related to ethereum/beacon-APIs#395 |
Would definitely prefer checksummed also as good standard practice. There's a lot of copying/pasting with these addresses and we should do our part to steward this practice. My preference is ethereum/beacon-APIs#396 over 395. Thanks for opening the PRs. |
Beacon APIs v2.4.0 introduce a new eventstream example that do not pass currently on lodestar.
The text was updated successfully, but these errors were encountered: