Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-55 mixed-case checksum address encoding for execution address #6211

Closed
nflaig opened this issue Dec 20, 2023 · 0 comments · Fixed by #6355
Closed

ERC-55 mixed-case checksum address encoding for execution address #6211

nflaig opened this issue Dec 20, 2023 · 0 comments · Fixed by #6355
Labels
good first issue Issues that are suitable for first-time contributors. meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.

Comments

@nflaig
Copy link
Member

nflaig commented Dec 20, 2023

Problem description

Based on discussion in ethereum/beacon-APIs#395 it would be good practice to implement ERC-55 mixed-case checksum address encoding for execution addresses.

There is an open PR to push for a standardization on the Beacon API spec ethereum/beacon-APIs#396, but whether or not this gets merged we might still wanna implement this in Lodestar.

Solution description

We could use a similar approach as Teku (Eth1Address.java), they just extend the Bytes20 SSZ type and override the relevant methods.

Execution address type is defined here

export const ExecutionAddress = Bytes20;

It is only used in three other types

export const Withdrawal = new ContainerType(

export const BLSToExecutionChange = new ContainerType(

export const ExecutionPayload = new ContainerType(

Additional context

There is a related issue regarding execution address formatting #6167. To pass the spec tests we also need the Beacon API spec itself to use consistent formatting.

@nflaig nflaig added the meta-feature-request Issues to track feature requests. label Dec 20, 2023
@philknows philknows added the scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling. label Jan 11, 2024
@nflaig nflaig added the good first issue Issues that are suitable for first-time contributors. label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. meta-feature-request Issues to track feature requests. scope-interop Issues that fix interop issues between Lodestar and CL, EL or tooling.
Projects
None yet
2 participants