Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kintsugi specs 🍵 (the Merge November sprint PR) #3418

Merged
merged 23 commits into from
Nov 15, 2021

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Nov 5, 2021

Motivation

PR is to implement Kintsugi 🍵 (the Merge November sprint)
Description

Consensus specs PR to implement. #3410

Test Milestones

Moved Below to seperate task list #3425

  • --terminal-block-hash-override?
  • --terminal-block-hash-epoch-override?

Closes #issue_number
#3410
Steps to test or reproduce

@codeclimate
Copy link

codeclimate bot commented Nov 5, 2021

Code Climate has analyzed commit c15bf07 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 4

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #3418 (c15bf07) into master (08dbb21) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   38.21%   38.19%   -0.02%     
==========================================
  Files         303      302       -1     
  Lines        7890     7894       +4     
  Branches     1207     1216       +9     
==========================================
  Hits         3015     3015              
- Misses       4734     4738       +4     
  Partials      141      141              

@g11tech g11tech force-pushed the kintsugi branch 2 times, most recently from 3034117 to 3dcdcf2 Compare November 8, 2021 15:08
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🔥 Thanks for the push of timely delivering this

packages/fork-choice/src/forkChoice/forkChoice.ts Outdated Show resolved Hide resolved
packages/fork-choice/src/forkChoice/forkChoice.ts Outdated Show resolved Hide resolved
packages/lodestar/src/chain/factory/block/body.ts Outdated Show resolved Hide resolved
packages/lodestar/src/chain/validation/block.ts Outdated Show resolved Hide resolved
packages/params/test/e2e/ensure-config-is-synced.test.ts Outdated Show resolved Hide resolved
packages/params/src/presets/minimal/index.ts Show resolved Hide resolved
@dapplion
Copy link
Contributor

dapplion commented Nov 9, 2021

@g11tech New specs version released already 💯 https://github.com/ethereum/consensus-specs/releases/tag/v1.1.5 please take a look. You can either do the changes on top of this PR or let's merge this one first and do the new 1.1.5 changes in a follow up PR.

@g11tech g11tech mentioned this pull request Nov 10, 2021
3 tasks
@g11tech
Copy link
Contributor Author

g11tech commented Nov 10, 2021

@g11tech New specs version released already 100 https://github.com/ethereum/consensus-specs/releases/tag/v1.1.5 please take a look. You can either do the changes on top of this PR or let's merge this one first and do the new 1.1.5 changes in a follow up PR.

@dapplion
this is done and committed into this PR as tasks were minor 👍 (have moved two issues GOSSIP/CHUNK size and processOperations dedup into new tracker #3425 for easier management)
also the geth merge interop is done for m1, a a small part of m2 as well (runGethPostMerge)

@g11tech g11tech marked this pull request as ready for review November 10, 2021 07:25
@dapplion dapplion changed the title Kintsugi 🍵 (the Merge November sprint PR) Implement Kintsugi specs 🍵 (the Merge November sprint PR) Nov 10, 2021
@dapplion
Copy link
Contributor

dapplion commented Nov 15, 2021

To keep this PR simple can you please drop all the recent commits regarding optimistic sync and add them in a new PR?

Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much for leading this push 🔥 excellent!

For upcoming PR on fast moving targets like this please keep PRs focus and atomic to prevent reviewers from having to review the same work +10 times. For example in this case building a new branch that fork from this PR head and creating the new PR once this is merge after a rebase.

@dapplion dapplion merged commit 90c7299 into ChainSafe:master Nov 15, 2021
@g11tech
Copy link
Contributor Author

g11tech commented Nov 15, 2021

Looks great! Thank you so much for leading this push fire excellent!

For upcoming PR on fast moving targets like this please keep PRs focus and atomic to prevent reviewers from having to review the same work +10 times. For example in this case building a new branch that fork from this PR head and creating the new PR once this is merge after a rebase.

👍 and Thank you! 🙂

@g11tech g11tech deleted the kintsugi branch November 15, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants