-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Kintsugi specs 🍵 (the Merge November sprint PR) #3418
Conversation
Code Climate has analyzed commit c15bf07 and detected 4 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #3418 +/- ##
==========================================
- Coverage 38.21% 38.19% -0.02%
==========================================
Files 303 302 -1
Lines 7890 7894 +4
Branches 1207 1216 +9
==========================================
Hits 3015 3015
- Misses 4734 4738 +4
Partials 141 141 |
…_forkchoice... 2711
… remove gas validation(2699)
3034117
to
3dcdcf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 🔥 Thanks for the push of timely delivering this
@g11tech New specs version released already 💯 https://github.com/ethereum/consensus-specs/releases/tag/v1.1.5 please take a look. You can either do the changes on top of this PR or let's merge this one first and do the new 1.1.5 changes in a follow up PR. |
…, tbh activation check(2712) already correct
@dapplion |
To keep this PR simple can you please drop all the recent commits regarding optimistic sync and add them in a new PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you so much for leading this push 🔥 excellent!
For upcoming PR on fast moving targets like this please keep PRs focus and atomic to prevent reviewers from having to review the same work +10 times. For example in this case building a new branch that fork from this PR head and creating the new PR once this is merge after a rebase.
👍 and Thank you! 🙂 |
Motivation
PR is to implement Kintsugi 🍵 (the Merge November sprint)
Description
Consensus specs PR to implement. #3410
Test Milestones
1.1.41.1.5Moved Below to seperate task list #3425
--terminal-block-hash-override
?--terminal-block-hash-epoch-override
?Closes #issue_number
#3410
Steps to test or reproduce