-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eth1 tracker improvements #3930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3930 +/- ##
==========================================
+ Coverage 36.32% 36.63% +0.30%
==========================================
Files 324 324
Lines 9059 9140 +81
Branches 1453 1485 +32
==========================================
+ Hits 3291 3348 +57
- Misses 5597 5611 +14
- Partials 171 181 +10 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Apr 25, 2022
wemeetagain
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the following eth1 desposit tracker behavior :
deployContract
. This has been reported by MarekM from nethermind. This PR wouldn't attempt to make those calls to the tracker unless remoteFollowBlock has actually reached deployContract.Closes #3851