Fix deserializeEnrSubnets #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3956 +/- ##
==========================================
- Coverage 36.33% 36.26% -0.07%
==========================================
Files 324 324
Lines 9063 9099 +36
Branches 1455 1465 +10
==========================================
+ Hits 3293 3300 +7
- Misses 5597 5626 +29
Partials 173 173 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Apr 28, 2022
dadepo
reviewed
Apr 28, 2022
| const bytesBuf = Buffer.from(bytes, "hex"); | ||
| it(`Deserialize attnet ${bytes}`, () => { | ||
| expect( | ||
| deserializeEnrSubnets(bytesBuf, ATTESTATION_SUBNET_COUNT).slice(0, ATTESTATION_SUBNET_COUNT) |
There was a problem hiding this comment.
seeing this has already been merged, this is more of a question...is the slice needed in the test? I removed it, that is:
expect(deserializeEnrSubnets(bytesBuf, ATTESTATION_SUBNET_COUNT)).to.deep.equal(bools)
and the tests still passed alright.
There was a problem hiding this comment.
yaah it's not really needed, it's only needed for sync committee, the test above I guess. However the test overall still serves our purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Lodestar node is not able to connect to an attestation subnet peer because
deserializeEnrSubnetsalways return an empty arrayDescription
Fix
deserializeEnrSubnetscloses #3940