Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @chainsafe/abort-controller #4064

Merged
merged 1 commit into from
May 26, 2022

Conversation

wemeetagain
Copy link
Member

Motivation

Since we're now using node 16, we don't need our own implementation of AbortController

Description

Remove the dependency

@wemeetagain wemeetagain requested a review from a team as a code owner May 25, 2022 19:24
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 21e55b9 Previous: 1031e7e Ratio
BeaconState.hashTreeRoot - No change 445.00 ns/op 476.00 ns/op 0.93
BeaconState.hashTreeRoot - 1 full validator 55.848 us/op 67.531 us/op 0.83
BeaconState.hashTreeRoot - 32 full validator 549.41 us/op 659.07 us/op 0.83
BeaconState.hashTreeRoot - 512 full validator 6.5110 ms/op 7.0369 ms/op 0.93
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 71.735 us/op 83.214 us/op 0.86
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 976.66 us/op 1.1256 ms/op 0.87
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 14.418 ms/op 14.999 ms/op 0.96
BeaconState.hashTreeRoot - 1 balances 54.702 us/op 65.071 us/op 0.84
BeaconState.hashTreeRoot - 32 balances 467.68 us/op 564.46 us/op 0.83
BeaconState.hashTreeRoot - 512 balances 4.6782 ms/op 5.4368 ms/op 0.86
BeaconState.hashTreeRoot - 250000 balances 97.751 ms/op 115.08 ms/op 0.85
processSlot - 1 slots 11.635 us/op 11.806 us/op 0.99
processSlot - 32 slots 1.6293 ms/op 1.8300 ms/op 0.89
getCommitteeAssignments - req 1 vs - 250000 vc 5.2979 ms/op 5.4199 ms/op 0.98
getCommitteeAssignments - req 100 vs - 250000 vc 7.3195 ms/op 7.9948 ms/op 0.92
getCommitteeAssignments - req 1000 vs - 250000 vc 7.7771 ms/op 8.5456 ms/op 0.91
computeProposers - vc 250000 16.958 ms/op 17.096 ms/op 0.99
computeEpochShuffling - vc 250000 166.77 ms/op 169.75 ms/op 0.98
getNextSyncCommittee - vc 250000 276.14 ms/op 282.64 ms/op 0.98
altair processAttestation - 250000 vs - 7PWei normalcase 4.0197 ms/op 3.3138 ms/op 1.21
altair processAttestation - 250000 vs - 7PWei worstcase 5.5110 ms/op 4.8623 ms/op 1.13
altair processAttestation - setStatus - 1/6 committees join 198.48 us/op 165.11 us/op 1.20
altair processAttestation - setStatus - 1/3 committees join 380.76 us/op 324.71 us/op 1.17
altair processAttestation - setStatus - 1/2 committees join 535.43 us/op 469.62 us/op 1.14
altair processAttestation - setStatus - 2/3 committees join 689.07 us/op 626.70 us/op 1.10
altair processAttestation - setStatus - 4/5 committees join 954.73 us/op 869.74 us/op 1.10
altair processAttestation - setStatus - 100% committees join 1.1287 ms/op 1.0430 ms/op 1.08
altair processBlock - 250000 vs - 7PWei normalcase 26.170 ms/op 23.886 ms/op 1.10
altair processBlock - 250000 vs - 7PWei normalcase hashState 38.088 ms/op 34.589 ms/op 1.10
altair processBlock - 250000 vs - 7PWei worstcase 81.283 ms/op 76.333 ms/op 1.06
altair processBlock - 250000 vs - 7PWei worstcase hashState 99.951 ms/op 106.69 ms/op 0.94
altair processEth1Data - 250000 vs - 7PWei normalcase 893.39 us/op 694.82 us/op 1.29
altair processEpoch - mainnet_e81889 508.05 ms/op 525.92 ms/op 0.97
mainnet_e81889 - altair beforeProcessEpoch 151.39 ms/op 118.15 ms/op 1.28
mainnet_e81889 - altair processJustificationAndFinalization 21.659 us/op 20.298 us/op 1.07
mainnet_e81889 - altair processInactivityUpdates 11.363 ms/op 9.1920 ms/op 1.24
mainnet_e81889 - altair processRewardsAndPenalties 134.83 ms/op 109.77 ms/op 1.23
mainnet_e81889 - altair processRegistryUpdates 3.1180 us/op 3.1030 us/op 1.00
mainnet_e81889 - altair processSlashings 868.00 ns/op 999.00 ns/op 0.87
mainnet_e81889 - altair processEth1DataReset 854.00 ns/op 1.4510 us/op 0.59
mainnet_e81889 - altair processEffectiveBalanceUpdates 3.7692 ms/op 2.5883 ms/op 1.46
mainnet_e81889 - altair processSlashingsReset 4.4180 us/op 5.0750 us/op 0.87
mainnet_e81889 - altair processRandaoMixesReset 5.7770 us/op 6.0550 us/op 0.95
mainnet_e81889 - altair processHistoricalRootsUpdate 894.00 ns/op 1.6230 us/op 0.55
mainnet_e81889 - altair processParticipationFlagUpdates 2.6520 us/op 3.3640 us/op 0.79
mainnet_e81889 - altair processSyncCommitteeUpdates 613.00 ns/op 712.00 ns/op 0.86
mainnet_e81889 - altair afterProcessEpoch 193.93 ms/op 219.58 ms/op 0.88
altair processInactivityUpdates - 250000 normalcase 34.639 ms/op 37.648 ms/op 0.92
altair processInactivityUpdates - 250000 worstcase 28.335 ms/op 39.508 ms/op 0.72
altair processRewardsAndPenalties - 250000 normalcase 114.90 ms/op 120.67 ms/op 0.95
altair processRewardsAndPenalties - 250000 worstcase 112.69 ms/op 118.63 ms/op 0.95
altair processSyncCommitteeUpdates - 250000 291.86 ms/op 285.05 ms/op 1.02
Tree 40 250000 create 908.52 ms/op 671.40 ms/op 1.35
Tree 40 250000 get(125000) 286.29 ns/op 240.03 ns/op 1.19
Tree 40 250000 set(125000) 2.6323 us/op 1.8660 us/op 1.41
Tree 40 250000 toArray() 33.322 ms/op 28.546 ms/op 1.17
Tree 40 250000 iterate all - toArray() + loop 33.500 ms/op 24.952 ms/op 1.34
Tree 40 250000 iterate all - get(i) 111.60 ms/op 104.96 ms/op 1.06
MutableVector 250000 create 16.171 ms/op 19.484 ms/op 0.83
MutableVector 250000 get(125000) 13.099 ns/op 11.073 ns/op 1.18
MutableVector 250000 set(125000) 752.84 ns/op 450.92 ns/op 1.67
MutableVector 250000 toArray() 7.4884 ms/op 4.5785 ms/op 1.64
MutableVector 250000 iterate all - toArray() + loop 7.7646 ms/op 4.7534 ms/op 1.63
MutableVector 250000 iterate all - get(i) 3.4391 ms/op 2.9758 ms/op 1.16
Array 250000 create 6.8327 ms/op 4.5218 ms/op 1.51
Array 250000 clone - spread 3.5657 ms/op 2.0960 ms/op 1.70
Array 250000 get(125000) 1.5070 ns/op 1.1470 ns/op 1.31
Array 250000 set(125000) 1.4890 ns/op 1.1550 ns/op 1.29
Array 250000 iterate all - loop 170.87 us/op 150.93 us/op 1.13
effectiveBalanceIncrements clone Uint8Array 300000 100.63 us/op 35.146 us/op 2.86
effectiveBalanceIncrements clone MutableVector 300000 1.1740 us/op 710.00 ns/op 1.65
effectiveBalanceIncrements rw all Uint8Array 300000 252.67 us/op 247.35 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 237.03 ms/op 144.34 ms/op 1.64
aggregationBits - 2048 els - zipIndexesInBitList 37.826 us/op 22.406 us/op 1.69
regular array get 100000 times 67.472 us/op 63.767 us/op 1.06
wrappedArray get 100000 times 67.431 us/op 63.461 us/op 1.06
arrayWithProxy get 100000 times 30.019 ms/op 32.229 ms/op 0.93
ssz.Root.equals 559.00 ns/op 541.00 ns/op 1.03
byteArrayEquals 552.00 ns/op 460.00 ns/op 1.20
phase0 processBlock - 250000 vs - 7PWei normalcase 4.0216 ms/op 3.0980 ms/op 1.30
phase0 processBlock - 250000 vs - 7PWei worstcase 47.266 ms/op 50.084 ms/op 0.94
phase0 afterProcessEpoch - 250000 vs - 7PWei 186.13 ms/op 187.56 ms/op 0.99
phase0 beforeProcessEpoch - 250000 vs - 7PWei 105.17 ms/op 102.70 ms/op 1.02
phase0 processEpoch - mainnet_e58758 621.55 ms/op 582.49 ms/op 1.07
mainnet_e58758 - phase0 beforeProcessEpoch 262.97 ms/op 224.18 ms/op 1.17
mainnet_e58758 - phase0 processJustificationAndFinalization 21.941 us/op 19.020 us/op 1.15
mainnet_e58758 - phase0 processRewardsAndPenalties 130.77 ms/op 112.85 ms/op 1.16
mainnet_e58758 - phase0 processRegistryUpdates 10.081 us/op 10.137 us/op 0.99
mainnet_e58758 - phase0 processSlashings 825.00 ns/op 751.00 ns/op 1.10
mainnet_e58758 - phase0 processEth1DataReset 750.00 ns/op 733.00 ns/op 1.02
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 2.0377 ms/op 2.0243 ms/op 1.01
mainnet_e58758 - phase0 processSlashingsReset 5.0100 us/op 5.5550 us/op 0.90
mainnet_e58758 - phase0 processRandaoMixesReset 5.9250 us/op 5.4420 us/op 1.09
mainnet_e58758 - phase0 processHistoricalRootsUpdate 824.00 ns/op 779.00 ns/op 1.06
mainnet_e58758 - phase0 processParticipationRecordUpdates 5.3020 us/op 4.9290 us/op 1.08
mainnet_e58758 - phase0 afterProcessEpoch 159.90 ms/op 163.17 ms/op 0.98
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.9081 ms/op 2.2332 ms/op 1.30
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 3.1790 ms/op 2.1612 ms/op 1.47
phase0 processRegistryUpdates - 250000 normalcase 8.1490 us/op 7.2960 us/op 1.12
phase0 processRegistryUpdates - 250000 badcase_full_deposits 413.21 us/op 373.62 us/op 1.11
phase0 processRegistryUpdates - 250000 worstcase 0.5 224.86 ms/op 211.18 ms/op 1.06
phase0 getAttestationDeltas - 250000 normalcase 15.047 ms/op 11.096 ms/op 1.36
phase0 getAttestationDeltas - 250000 worstcase 15.022 ms/op 11.098 ms/op 1.35
phase0 processSlashings - 250000 worstcase 5.7115 ms/op 5.0782 ms/op 1.12
shuffle list - 16384 els 11.066 ms/op 11.539 ms/op 0.96
shuffle list - 250000 els 163.63 ms/op 165.65 ms/op 0.99
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 379.88 us/op 364.23 us/op 1.04
pass gossip attestations to forkchoice per slot 3.2854 ms/op 2.9432 ms/op 1.12
computeDeltas 4.1464 ms/op 4.3419 ms/op 0.95
computeProposerBoostScoreFromBalances 921.19 us/op 808.19 us/op 1.14
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.2581 ms/op 1.7404 ms/op 1.30
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 80.085 us/op 64.007 us/op 1.25
BLS verify - blst-native 1.8590 ms/op 2.1693 ms/op 0.86
BLS verifyMultipleSignatures 3 - blst-native 3.8096 ms/op 4.4765 ms/op 0.85
BLS verifyMultipleSignatures 8 - blst-native 8.2004 ms/op 9.6790 ms/op 0.85
BLS verifyMultipleSignatures 32 - blst-native 29.721 ms/op 35.180 ms/op 0.84
BLS aggregatePubkeys 32 - blst-native 40.448 us/op 47.250 us/op 0.86
BLS aggregatePubkeys 128 - blst-native 157.26 us/op 182.62 us/op 0.86
getAttestationsForBlock 69.684 ms/op 51.901 ms/op 1.34
isKnown best case - 1 super set check 440.00 ns/op 494.00 ns/op 0.89
isKnown normal case - 2 super set checks 427.00 ns/op 481.00 ns/op 0.89
isKnown worse case - 16 super set checks 436.00 ns/op 490.00 ns/op 0.89
CheckpointStateCache - add get delete 11.145 us/op 12.291 us/op 0.91
validate gossip signedAggregateAndProof - struct 4.2567 ms/op 5.0045 ms/op 0.85
validate gossip attestation - struct 2.0646 ms/op 2.3677 ms/op 0.87
altair verifyImport mainnet_s3766816:31 6.2793 s/op 6.8133 s/op 0.92
pickEth1Vote - no votes 2.1278 ms/op 2.1470 ms/op 0.99
pickEth1Vote - max votes 24.996 ms/op 22.179 ms/op 1.13
pickEth1Vote - Eth1Data hashTreeRoot value x2048 11.969 ms/op 13.263 ms/op 0.90
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 22.444 ms/op 24.034 ms/op 0.93
pickEth1Vote - Eth1Data fastSerialize value x2048 1.6510 ms/op 1.4464 ms/op 1.14
pickEth1Vote - Eth1Data fastSerialize tree x2048 16.861 ms/op 12.019 ms/op 1.40
bytes32 toHexString 1.1070 us/op 957.00 ns/op 1.16
bytes32 Buffer.toString(hex) 730.00 ns/op 754.00 ns/op 0.97
bytes32 Buffer.toString(hex) from Uint8Array 942.00 ns/op 1.0010 us/op 0.94
bytes32 Buffer.toString(hex) + 0x 739.00 ns/op 734.00 ns/op 1.01
Object access 1 prop 0.38600 ns/op 0.34300 ns/op 1.13
Map access 1 prop 0.29100 ns/op 0.31100 ns/op 0.94
Object get x1000 17.757 ns/op 11.353 ns/op 1.56
Map get x1000 0.97100 ns/op 0.98800 ns/op 0.98
Object set x1000 127.12 ns/op 67.819 ns/op 1.87
Map set x1000 77.762 ns/op 44.752 ns/op 1.74
Return object 10000 times 0.37790 ns/op 0.44030 ns/op 0.86
Throw Error 10000 times 5.9417 us/op 6.2835 us/op 0.95
enrSubnets - fastDeserialize 64 bits 2.9870 us/op 2.5170 us/op 1.19
enrSubnets - ssz BitVector 64 bits 810.00 ns/op 782.00 ns/op 1.04
enrSubnets - fastDeserialize 4 bits 431.00 ns/op 380.00 ns/op 1.13
enrSubnets - ssz BitVector 4 bits 775.00 ns/op 787.00 ns/op 0.98
prioritizePeers score -10:0 att 32-0.1 sync 2-0 99.105 us/op 81.428 us/op 1.22
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 141.80 us/op 126.45 us/op 1.12
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 235.56 us/op 189.24 us/op 1.24
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 393.34 us/op 387.62 us/op 1.01
prioritizePeers score 0:0 att 64-1 sync 4-1 465.21 us/op 460.98 us/op 1.01
RateTracker 1000000 limit, 1 obj count per request 193.13 ns/op 199.15 ns/op 0.97
RateTracker 1000000 limit, 2 obj count per request 145.76 ns/op 145.55 ns/op 1.00
RateTracker 1000000 limit, 4 obj count per request 123.24 ns/op 117.12 ns/op 1.05
RateTracker 1000000 limit, 8 obj count per request 115.45 ns/op 104.49 ns/op 1.10
RateTracker with prune 4.9820 us/op 3.6020 us/op 1.38
array of 16000 items push then shift 3.1917 us/op 51.598 us/op 0.06
LinkedList of 16000 items push then shift 27.725 ns/op 16.368 ns/op 1.69
array of 16000 items push then pop 257.29 ns/op 187.51 ns/op 1.37
LinkedList of 16000 items push then pop 23.020 ns/op 13.909 ns/op 1.66
array of 24000 items push then shift 4.5471 us/op 77.363 us/op 0.06
LinkedList of 24000 items push then shift 28.894 ns/op 18.350 ns/op 1.57
array of 24000 items push then pop 224.96 ns/op 168.50 ns/op 1.34
LinkedList of 24000 items push then pop 24.142 ns/op 14.708 ns/op 1.64
intersect bitArray bitLen 8 11.760 ns/op 11.011 ns/op 1.07
intersect array and set length 8 174.73 ns/op 120.15 ns/op 1.45
intersect bitArray bitLen 128 61.971 ns/op 58.954 ns/op 1.05
intersect array and set length 128 2.3225 us/op 1.6779 us/op 1.38

by benchmarkbot/action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants