Add execution payload header to light client header capella onwards #5027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
g11tech
commented
Jan 20, 2023
g11tech
commented
Jan 20, 2023
packages/params/src/index.ts
Outdated
| @@ -186,6 +194,17 @@ export const FINALIZED_ROOT_GINDEX = 105; | |||
| */ | |||
| export const FINALIZED_ROOT_DEPTH = 6; | |||
| export const FINALIZED_ROOT_INDEX = 41; | |||
|
|
|||
| // TODO: add correct values here | |||
| export const EXECUTION_PAYLOAD_GINDEX = 105; | |||
There was a problem hiding this comment.
TODO: cal and update corrected
There was a problem hiding this comment.
looks to be 33
types.ssz.capella.LightClientUpdate.getPathInfo(['attestedHeader', 'execution']).gindex
// 33There was a problem hiding this comment.
the proof is from the block body to payload, so updated accordingly
g11tech
force-pushed
the
g11tech/capella-lightclientheader
branch
from
74af4da to
30911c9
Compare
This was referenced Feb 5, 2023
g11tech
force-pushed
the
g11tech/capella-lightclientheader
branch
from
1a185ca to
e218dd3
Compare
wemeetagain
reviewed
Feb 8, 2023
| constructor(config: IChainForkConfig, db: IDatabaseController<Uint8Array, Uint8Array>) { | ||
| // Pick some type but won't be used | ||
| super(config, db, Bucket.lightClient_bestLightClientUpdate, ssz.altair.LightClientUpdate); |
There was a problem hiding this comment.
can we use new buckets here and below to make migration easier
There was a problem hiding this comment.
bump the bucket number for this key?
wemeetagain
approved these changes
Feb 8, 2023
twoeths
approved these changes
Feb 8, 2023
philknows
added
meta-breaking-change
wemeetagain
pushed a commit
that referenced
this pull request
Feb 27, 2023
…5027) * Add execution payload header to light client header capella onwards * add more forks * add allfork types * make other types multifork * make events multifork compatible * make lightclient routes multifork * update light-client transport * upgrade the blocktype on lightclient server import block * fixes * fix test * fix event serialization/deserilization type * update proof constants * fix payload index * update the light client update generation to multi fork * fix types * add spec override to pass specs * make event types allforks * make req/resp multifork * make types multifork throughout * fix the update serialize/deserialize * fix error log * better fork determination for update * fix the fork of finalized * fix tests * fix header upgradation
dapplion
added a commit
that referenced
this pull request
Feb 28, 2023
* v1.5.0 * Add validatior option to specify builder block selection strategy (#5064) * Add validatior option to specify builder block selection strategy * cleanup and improvements * server api fx * fix test * fix the testcase * Re-gossip bls changes if submitted earlier than capella (#5049) * Cache and retransmit bls changes if submitted early * regossip when synced on/post capella * fix tests * modify publish vs cache condition * add logging * add error logging * batchify the processing * fix some of the cases * fix log issues * also delete included keys * fix lint * simplify gossip loop * fix build * refac to a versioned bls change store * update * logging improvements * improve logging and finish behavior * cleanup * Rename eip4844 fork as Deneb (#5082) * Fix and extract payload to header conversion (#5101) * Remove unused eslint disable directives (#5046) * Add execution payload header to light client header capella onwards (#5027) * Add execution payload header to light client header capella onwards * add more forks * add allfork types * make other types multifork * make events multifork compatible * make lightclient routes multifork * update light-client transport * upgrade the blocktype on lightclient server import block * fixes * fix test * fix event serialization/deserilization type * update proof constants * fix payload index * update the light client update generation to multi fork * fix types * add spec override to pass specs * make event types allforks * make req/resp multifork * make types multifork throughout * fix the update serialize/deserialize * fix error log * better fork determination for update * fix the fork of finalized * fix tests * fix header upgradation * Fix zero finalized header in lightclient update gen (#5121) * Schedule capella on sepolia (#5127) * Get the capella builder functional (#5179) * Allow blsChange reprocess/republish via API submission (#5185) * Fix gossiping blsChange on submit if post capella * comment improvement * Use new db bucket for light client updates (#5205) --------- Co-authored-by: Cayman <caymannava@gmail.com> Co-authored-by: g11tech <develop@g11tech.io> Co-authored-by: Nico Flaig <nflaig@protonmail.com>
|
🎉 This PR is included in v1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add execution payload header to light client header capella onwards
Part of