Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add presets and ssz types for EIP-7549 #6715

Merged
merged 11 commits into from
May 4, 2024
Merged

feat: add presets and ssz types for EIP-7549 #6715

merged 11 commits into from
May 4, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Apr 29, 2024 •
edited
Loading

Add presets and ssz types for EIP-7549.

Directly extract committee bits and other fields from serialized electra.attestations

Part of #6341 and #6689

@ensi321 ensi321 requested a review from a team as a code owner April 29, 2024 08:01
@ensi321 ensi321 marked this pull request as draft April 29, 2024 08:57
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.38562% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (electra-fork@4828e06). Click here to learn what that means.

Additional details and impacted files 
@@               Coverage Diff               @@
##             electra-fork    #6715   +/-   ##
===============================================
  Coverage                ?   62.03%           
===============================================
  Files                   ?      563           
  Lines                   ?    60081           
  Branches                ?     1905           
===============================================
  Hits                    ?    37272           
  Misses                  ?    22768           
  Partials                ?       41

@ensi321 ensi321 marked this pull request as ready for review April 29, 2024 14:16
wemeetagain
wemeetagain reviewed May 1, 2024
View reviewed changes
packages/types/src/electra/sszTypes.ts Outdated Show resolved Hide resolved
packages/types/src/electra/types.ts Outdated Show resolved Hide resolved
packages/types/src/electra/sszTypes.ts Show resolved Hide resolved
packages/types/src/electra/sszTypes.ts Outdated Show resolved Hide resolved
@ensi321 ensi321 merged commit b19abdf into electra-fork May 4, 2024
15 of 17 checks passed
@ensi321 ensi321 deleted the nc/7549-1 branch May 4, 2024 13:24
@ensi321 ensi321 mentioned this pull request May 4, 2024
Open
12 tasks
g11tech pushed a commit that referenced this pull request May 4, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
46ae715 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
g11tech pushed a commit that referenced this pull request May 24, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
0e67967 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
g11tech pushed a commit to g11tech/lodestar that referenced this pull request Jun 19, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (ChainSafe#6715)
ea52e9d 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
g11tech added a commit that referenced this pull request Jun 25, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
221cb7a 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Jun 25, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
768f42b 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Jul 1, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
ffaa950 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Jul 30, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
8688b87 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Jul 31, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
1acdffb 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Aug 2, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
755a111 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Aug 9, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
f1ced8b 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Aug 9, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
54220d8 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Aug 23, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
9fcf5df 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
g11tech added a commit that referenced this pull request Aug 27, 2024
@ensi321 @twoeths @g11tech
feat: add presets and ssz types for EIP-7549 (#6715)
bef3eff 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
philknows pushed a commit that referenced this pull request Sep 3, 2024
@ensi321 @twoeths
@g11tech @philknows
feat: add presets and ssz types for EIP-7549 (#6715)
883b95f 
* Add types

* Update unit test

* lint

* Address comments

* Address comments

* Lint

* Update packages/beacon-node/src/util/sszBytes.ts

Co-authored-by: tuyennhv <tuyen@chainsafe.io>

* Add isElectraAttestation

* Update unit test

* Update unit test

* chore: add comments for sszBytes.ts

---------

Co-authored-by: tuyennhv <tuyen@chainsafe.io>
Co-authored-by: Tuyen Nguyen <vutuyen2636@gmail.com>
Co-authored-by: Gajinder <develop@g11tech.io>
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain left review comments

@twoeths twoeths twoeths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ensi321 @wemeetagain @twoeths