-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keymanager endpoint to retrieve proposer config #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default parsing can't handle BigInt
This reverts commit 01fcea7.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7210 +/- ##
=========================================
Coverage 49.21% 49.22%
=========================================
Files 598 598
Lines 39803 39820 +17
Branches 2102 2099 -3
=========================================
+ Hits 19588 19600 +12
- Misses 20175 20182 +7
+ Partials 40 38 -2 |
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
g11tech
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed on discord with @g11tech this can be useful for some users.
Description
Adds
GET /eth/v0/validator/{pubkey}/proposer_config
endpoint to keymanager api. As this is non-standardized it's versioned as v0 (similar to proof apis) as it might be part of the spec in the future which would then be v1.The return format of this api might change based on proposer config format which is still considered an alpha feature.