Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement partial spec changes for v1.5.0-alpha.10 #7288

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

@ensi321 ensi321 requested a review from a team as a code owner December 9, 2024 18:51
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (1873e97) to head (525db62).
Report is 11 commits behind head on devnet-5.

Additional details and impacted files
@@            Coverage Diff            @@
##           devnet-5    #7288   +/-   ##
=========================================
  Coverage     48.80%   48.81%           
=========================================
  Files           603      603           
  Lines         40404    40401    -3     
  Branches       2065     2065           
=========================================
- Hits          19721    19720    -1     
+ Misses        20645    20643    -2     
  Partials         38       38           

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ensi321 ensi321 merged commit 21b7d61 into devnet-5 Dec 14, 2024
14 of 17 checks passed
@ensi321 ensi321 deleted the nc/partial-alpha-10 branch December 14, 2024 00:18
ensi321 added a commit that referenced this pull request Dec 14, 2024
* Rename PartialPendingWithdrawal field

* do not change creds type on consolidation

* Use validator EB to process pending consolidation

* lint
ensi321 added a commit that referenced this pull request Dec 14, 2024
* Rename PartialPendingWithdrawal field

* do not change creds type on consolidation

* Use validator EB to process pending consolidation

* lint
ensi321 added a commit that referenced this pull request Dec 17, 2024
* Rename PartialPendingWithdrawal field

* do not change creds type on consolidation

* Use validator EB to process pending consolidation

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants