Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deployment gh action #219

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix: deployment gh action #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7647349
fix: deployment gh action
Oct 26, 2022
2b8917e
fix: yaml format
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build_prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: Build & Push Docker Image to AWS ECR
on:
push:
tags:
- v*
- v1.*

env:
AWS_REGION: ${{ secrets.AWS_REGION }}
Expand Down Expand Up @@ -49,4 +49,4 @@ jobs:
push: true
tags: |
${{ env.AWS_ACCOUNT_ID }}.dkr.ecr.${{ env.AWS_REGION }}.amazonaws.com/${{ env.AWS_ECR_REPO }}:latest
${{ env.AWS_ACCOUNT_ID }}.dkr.ecr.${{ env.AWS_REGION }}.amazonaws.com/${{ env.AWS_ECR_REPO }}:${{ steps.vars.outputs.sha }}
${{ env.AWS_ACCOUNT_ID }}.dkr.ecr.${{ env.AWS_REGION }}.amazonaws.com/${{ env.AWS_ECR_REPO }}:${{ steps.vars.outputs.sha }}
4 changes: 2 additions & 2 deletions .github/workflows/deploy_prod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: Deploy ECS Prod
on:
push:
tags:
- v*
- v1.*

env:
AWS_REGION: ${{ secrets.AWS_REGION }}
Expand Down Expand Up @@ -39,4 +39,4 @@ jobs:
task-definition: ecs/task_definition_${{ env.ENVIRONMENT }}.json
service: nodewatch-${{ env.ENVIRONMENT }}-service
cluster: nodewatch-${{ env.ENVIRONMENT }}-cluster
wait-for-service-stability: true
wait-for-service-stability: true