Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend change password ui test #2156

Closed
asnaith opened this issue May 26, 2022 · 2 comments
Closed

Extend change password ui test #2156

asnaith opened this issue May 26, 2022 · 2 comments
Labels
Testing Added to issues to signal that it is part of an epic

Comments

@asnaith
Copy link
Member

asnaith commented May 26, 2022

Task

Extend the current change password test to include signing out and signing back in with the new password.

At the moment we're just assuming the change was successful if the change password elements collapse after submitting the change.

Additional Notes

Whilst under test in cypress, it seems to lose the wallet address it was using after signing out. When we try to sign back in we are prompted to create a password not enter one (because it starts using a different wallet address).

We need to work out what's happening with the address / fake metamask window that we are using, the same wallet address is should be maintained for the whole duration of the test.

@Tbaut
Copy link
Collaborator

Tbaut commented May 30, 2022

This is a tricky one because the web3login cypress function either always uses a random new account, or it uses a fixed hard-coded one, with a fixed password. And if you start changing the password for the hardcoded account, this will conflict with other tests. If we want to fiddle with storing the state of the current test sessions, it means we'll have some stateful tests, which is not really elegant.
We are now pretty much in the realm of testing weather the api did its job, which is not really the idea. I think it might be better to just verify that the call to the api happened, and that we get 200 or something back.

@FSM1 FSM1 added the Testing Added to issues to signal that it is part of an epic label May 30, 2022
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 13, 2022

closing for the reasons I mentioned.

@Tbaut Tbaut closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Added to issues to signal that it is part of an epic
Projects
None yet
Development

No branches or pull requests

3 participants