Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ui tests for change password #2151

Merged
merged 6 commits into from
May 30, 2022
Merged

Add ui tests for change password #2151

merged 6 commits into from
May 30, 2022

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented May 24, 2022 •
edited
Loading

closes #2137

@asnaith asnaith added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label May 24, 2022
@render
Copy link

render bot commented May 24, 2022

Your Render PR Server URL is https://chainsafe-components-stage-pr-2151.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca6ltg397ej6nr5hdidg.

@render
Copy link

render bot commented May 24, 2022

Your Render PR Server URL is https://files-ui-stage-pr-2151.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca6lth397ej6nr5hdii0.

@render
Copy link

render bot commented May 24, 2022

Your Render PR Server URL is https://storage-ui-stage-pr-2151.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ca6lti397ej6nr5hdj4g.

@ChainSafe ChainSafe deleted a comment from juans-chainsafe May 26, 2022
@asnaith asnaith marked this pull request as ready for review May 26, 2022 22:43
asnaith
asnaith commented May 26, 2022
View reviewed changes
packages/files-ui/cypress/tests/settings-spec.ts
settingsPage.passwordInput().should("not.exist")
settingsPage.confirmPasswordInput().should("not.exist")
settingsPage.changePasswordButton().should("not.exist")
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to expand this check to include logging out and logging back in with the new password but I'm experiencing some weirdness with the fake metamask window / test wallet address. I'll look at that in a separate issue (#2156) so that this can be merged before I'm back online.

Tbaut
Tbaut approved these changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, as suggested in the followup issue, we may want to make sure the call to the api is made, with the right data, but we can add this later when closing the said issue.

juans-chainsafe
juans-chainsafe approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! agree with Tbaut with the assertion of the api call, but if we can do it in the new issue, then we can close this one

@Tbaut Tbaut merged commit 6c3ebf1 into dev May 30, 2022
@Tbaut Tbaut deleted the mnt/change-password-tests-2137 branch May 30, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@juans-chainsafe juans-chainsafe juans-chainsafe approved these changes

@tanmoyAtb tanmoyAtb Awaiting requested review from tanmoyAtb

@FSM1 FSM1 Awaiting requested review from FSM1

Assignees
No one assigned
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ui test coverage for changing password
3 participants
@asnaith @Tbaut @juans-chainsafe