Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting a slash in folder name creates subfolder #777

Closed
sweetpea22 opened this issue Feb 10, 2021 · 3 comments · Fixed by #899
Closed

Putting a slash in folder name creates subfolder #777

sweetpea22 opened this issue Feb 10, 2021 · 3 comments · Fixed by #899
Assignees
Labels
Priority: P1 High Added to issues relating to a high severity bugs.

Comments

@sweetpea22
Copy link
Contributor

I think this was intentional, but creating a folder with name "Design/Illustration" creates a subfolder. Is there a way to escape this or make a different shortcut? Worried users would find this surprising. What do you think?

@kalambet
Copy link
Member

kalambet commented Feb 10, 2021

So from the filesystem perspective it's rather feature than a bug :)
Like if you upload several files with full names like:

/folder1/folder2/file.txt
/folder1/file.txt
/folder1/folder3/Very Important Papers.pdf

And you don't need to create all those folders there will be there for you automatically.
So I'd treat slashes in folder names as a way to create folder structure.

@sweetpea22
Copy link
Contributor Author

Okay, that makes a lot of sense. Think this is a good one to AB test with users, and see if it's acceptable to them when they're entering a name from text input

@FSM1
Copy link
Contributor

FSM1 commented Mar 10, 2021

Prevent user's from inputting a / in the folder name, and check whether file name is validated as well

Also see #838

@FSM1 FSM1 added the Priority: P1 High Added to issues relating to a high severity bugs. label Apr 7, 2021
@tanmoyAtb tanmoyAtb self-assigned this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 High Added to issues relating to a high severity bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants