Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder validation #899

Merged
merged 4 commits into from
Apr 9, 2021
Merged

folder validation #899

merged 4 commits into from
Apr 9, 2021

Conversation

tanmoyAtb
Copy link
Contributor

@tanmoyAtb tanmoyAtb commented Apr 8, 2021

closes #777

File name validation already in place

@render
Copy link

render bot commented Apr 8, 2021

@render
Copy link

render bot commented Apr 8, 2021

@render
Copy link

render bot commented Apr 8, 2021

@tanmoyAtb tanmoyAtb self-assigned this Apr 8, 2021
@tanmoyAtb tanmoyAtb marked this pull request as draft April 8, 2021 15:44
@tanmoyAtb tanmoyAtb marked this pull request as ready for review April 8, 2021 15:50
Copy link
Contributor

@RyRy79261 RyRy79261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I agree with @Tbaut suggestion so just that and we're good

tanmoyAtb and others added 2 commits April 9, 2021 18:27
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested approval, code looks good :)

@tanmoyAtb tanmoyAtb merged commit 38a79ed into dev Apr 9, 2021
@tanmoyAtb tanmoyAtb deleted the fix/folder-validation-777 branch April 9, 2021 13:41
FSM1 added a commit that referenced this pull request Apr 12, 2021
Crash when going back after having selected Google auth #860 (PR #871)
Login optimizations (PR #879)
Minor fixes + Updates to color manipulator (#874)
Merge pull request #879 from ChainSafe/fix/login-optimizations
Merge pull request #887 from ChainSafe/fix/tbaut-hover-color
Merge pull request #886 from ChainSafe/feat/tkey-darkmode
Remove code duplication (#889)
Merge pull request #895 from ChainSafe/fix/select-all-892
Merge pull request #896 from ChainSafe/fix/mouse-highlight-issue-890
Merge pull request #894 from ChainSafe/fix/mobile-spinner-893
Merge pull request #877 from ChainSafe/feat/tbaut-settings-security-846
folder validation (#899)
saved browsers settings (#865)
Prevent the whole app from rerendering every 5s (#909)
Merge pull request #911 from ChainSafe/fix/share-transfer-modal-on-ta… …
Merge pull request #905 from ChainSafe/fix/bin-file-view-873 …
Merge pull request #906 from ChainSafe/feat/home-folder-nav-885 …
Merge pull request #907 from ChainSafe/fix/search-bucket-to-reset-on-…
Fix: Search results all show as files (#914) …
Fix double click opening the next file preview (#915) …
Rename tooltip and fixes (#912) …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Putting a slash in folder name creates subfolder
4 participants