Storage app skeleton #1067
Merged
Storage app skeleton #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://files-ui-stage-pr-1067.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2ofa20irho5ka7j2b3g. |
RyRy79261
approved these changes
May 31, 2021
tanmoyAtb
reviewed
May 31, 2021
tanmoyAtb
reviewed
May 31, 2021
tanmoyAtb
reviewed
May 31, 2021
tanmoyAtb
reviewed
May 31, 2021
tanmoyAtb
reviewed
May 31, 2021
|
|
||
| <section className={classes.accountControls}> | ||
| <MenuDropdown | ||
| title='TBC' |
There was a problem hiding this comment.
should use getProfileTitle
There was a problem hiding this comment.
There is currently no user context in this app. We will update this once development gets under way
tanmoyAtb
approved these changes
May 31, 2021
There was a problem hiding this comment.
Great stuff ! Looks good enough for a skeleton !
The OAuths redirects and app instances will need some work,
Some linting issues and unused variable lying around
I'm just worried that not being able to reuse the themes in other packages means we won't be able to reuse the common-modules package.
The theme and component packages have remained the same. The common-modules package was empty since I ran in to the same sort of issues originally trying to use it. |
…iles-ui into feat/storage-app-386
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
Merged
FSM1
added a commit
that referenced
this pull request
Jun 15, 2021
* Updated-labels * Removed Reference dev * Update readme.md (#1083) * Update readme.md * Update readme.md * Drop the last sentence from readme.md Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * Survey v2 for product market fit (#1082) * v2 * translatioin FR * more * lingui extract * with gradient * Update packages/files-ui/src/Components/SurveyBanner.tsx Co-authored-by: Cindy Chau <47398578+sweetpea22@users.noreply.github.com> * lingui extract * Update packages/files-ui/src/locales/fr/messages.po * different gradient for better readability Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Cindy Chau <47398578+sweetpea22@users.noreply.github.com> * Storage app skeleton (#1067) * remove old chainsafe x package * initial app skeleton and refactor * fix api client issues * remove old chainsafe x package * initial app skeleton and refactor * fix api client issues * remove tests * Apply suggestions from code review Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * Update packages/storage-ui/src/Contexts/StorageApiContext.tsx Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * make eslint :D again * remove unneeded login methods Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * Update release-drafter with the new name (#1088) * Update release-drafter.yml * Update .github/release-drafter.yml Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * Add page object pattern for ui tests (#1080) * Add PR labeler based on the branch name (#1089) * pr labeler * with workflow * for PR * back to open Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * passwordless login (#1072) * UI ready * UI ready and trans ready * work in progress * lingui extract * passwordless login * code and login * loaders on passwordless login * wallet names * lingui extract * Delete package.json * feedback * lingui extract * Cleanup InitialScreen (#1092) * cleanup * spaces * compile update * fr translation and ternarry nits Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> Co-authored-by: Thibaut Sardan <github@thib.top> * Fix Bin Preview (#1093) * update to new api client and wire up download * cypress bump to avoid having 2 packages Co-authored-by: Thibaut Sardan <github@thib.top> * Update pr-labeler.yml (#1099) * Update pr-labeler.yml * Update pr-labeler.yml * Update pr-labeler.yml * Update pr-labeler.yml * Update pr-labeler.yml * Apply suggestions from code review * Update .github/workflows/pr-labeler.yml Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * removed redundant stage & prod release which is replaced by release drafter; updated readme (#1102) Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Fix InitialScreen.tsx Error messages (#1100) * Update InitialScreen.tsx * Update packages/files-ui/src/Components/Modules/LoginModule/InitialScreen.tsx Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * Deprecate all `files/` endpoints (#1095) * deprecate all `files/` endpoints * clean up remaining todos * Update packages/files-ui/src/Components/Modules/FileBrowsers/BinFileBrowser.tsx Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * fix lint * update to latest api client Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * Files API Client in Tests (#1097) * use api client in tests * fix detached from the Dom (#1096) Co-authored-by: Thibaut Sardan <github@thib.top> * make eslint :D * update yarn lock * update commands Co-authored-by: Thibaut Sardan <github@thib.top> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Recover files with move file modal (#1094) * recover files in modal * move file restructure * lingui extract * deprecate all `files/` endpoints * clean up remaining todos * Update packages/files-ui/src/Components/Modules/FileBrowsers/BinFileBrowser.tsx Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * fix lint * move file update * lint and installs * Update packages/files-ui/src/Components/Modules/FileBrowsers/MoveFileModal.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/files-ui/src/Components/Modules/FileBrowsers/MoveFileModal.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/files-ui/src/locales/fr/messages.po Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/files-ui/src/Components/Modules/FileBrowsers/MoveFileModal.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/files-ui/src/locales/fr/messages.po Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Michael Yankelev <myankelev@gmail.com> Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update file management ui tests (#1113) * Fix mistake * Update homepage page object and file management tests * Fix typo in test identifier * update homePage object * use api client in tests * fix detached from the Dom (#1096) Co-authored-by: Thibaut Sardan <github@thib.top> * wip * Increase cypress page load timeout * Rename element and update page object * Update file management ui tests * Remove white space Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Revert to default page load timeout Co-authored-by: Michael Yankelev <myankelev@gmail.com> Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> Co-authored-by: Thibaut Sardan <github@thib.top> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Wording for backup **secret** phrase (#1116) * wording for secret phrase * lingui extract * Update packages/files-ui/src/locales/fr/messages.po Co-authored-by: GitHub Actions <actions@github.com> * CIDs overview (#1117) * wip * v1.14 * v1.15-rc1 * show Cids * buckets in nav bar * cleanup * cid instead of pin * in menus * login on refresh - storage ui (#1109) * with local storage * local or session * v2 api spec * v2.1 Co-authored-by: Thibaut Sardan <github@thib.top> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> * Put eslint at top level since it's shared by all packages (#1115) * eslint at top level * fix lint Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * Allow to unpin a Cid (#1110) * wip * v1.14 * v1.15-rc1 * show Cids * buckets in nav bar * cleanup * cid instead of pin * in menus * unpin and styling * lint * eslint 6.8 to make react-script happy (#1121) * Add identifier for the upload status box (#1122) Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * tkey address in settings (#1112) * key address added * lingui extract * Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * Update packages/files-ui/src/Components/Modules/Settings/Profile.tsx Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> * lingui extract * renames Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Michael Yankelev <12774278+FSM1@users.noreply.github.com> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Force refresh on buckets when deleting from bin (#1127) * Force refresh * Liniting * Linting * Added to upload * Copied across styling (#1125) Co-authored-by: Thibaut Sardan <github@thib.top> * Dnd Fix destination path (#1118) * fix destination path * Implement suggestion Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> * Handle walletconnect signature request (#1124) * handle walletconnect signature request * Update packages/files-ui/src/Contexts/ThresholdKeyContext.tsx Co-authored-by: Ryan Noble <ryanjnoble@gmail.com> * fix lint Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: Ryan Noble <ryanjnoble@gmail.com> * Remove Facebook login (#1136) * hide facebook login * lingui extract Co-authored-by: GitHub Actions <actions@github.com> * email button disabled like others (#1137) Co-authored-by: Shiva <82167447+RamidiShiva@users.noreply.github.com> Co-authored-by: Cindy Chau <47398578+sweetpea22@users.noreply.github.com> Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com> Co-authored-by: Andrew Snaith <asnaith@users.noreply.github.com> Co-authored-by: Thibaut Sardan <github@thib.top> Co-authored-by: Priom Chowdhury <priom@chainsafe.io> Co-authored-by: Ryan Noble <ryanjnoble@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #386
Strange inter-package context issues prevented me from making use of the shared context package, which has now been deprecated. All contexts have been moved from the shared contexts package directly into the individual context folder in each of the repos.