-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared folder overview #1078
Shared folder overview #1078
Conversation
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
Your Render PR Server URL is https://files-ui-stage-pr-1078.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c2qla6girho589q1bf2g. |
…e/files-ui into feat/tbaut-shared-overview-1041
Your Render PR Server URL is https://storage-ui-stage-pr-1078.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3106h464ckh7frfhg60. |
…e/files-ui into feat/tbaut-shared-overview-1041
This pull request fixes 1 alert when merging d9e7e6d into f1852e9 - view on LGTM.com fixed alerts:
|
…e/files-ui into feat/tbaut-shared-overview-1041
let encryptionKey = "" | ||
|
||
switch(b.type) { | ||
case "csf": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question! any particular reason, not getting the key for csf ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each case option will fall through to the nearest implementation, so syntactically this is equivalent to :
case 'a': {
// do thing
break;
}
case 'b': {
// do thing
break
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, we do get the key for csf
, but we get the key in a similar way for both trash
and csf
so I grouped them.
One thing I noticed, I don't see uploads showing progress (downloads progress working). Not sure if its this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks smooth and ready to go :D,
There are some UI parts, specially the mobile view,
But thats for another issue.
Yup so just like I did for the Storage part, my goal was to have a working base PR for all the other issues to be tackled in parallel. We should def, add one for the mobile view because I didn't play with it at all and I def. expected things to break. For the upload, I guess you mean to add things to shared folder? This is also something that can be worked on in parallel. I thought there was an issue for that, but I'll add it now too. |
closes #1041