-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import CID #1128
Import CID #1128
Conversation
Your Render PR Server URL is https://files-ui-stage-pr-1128.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c31lmbc64ckjenonhmjg. |
Your Render PR Server URL is https://storage-ui-stage-pr-1128.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c31lmbs64ckjenonhn40. |
Definitely not expected, this came from an error in the api-spec. Fixed it and published it, this is now sorted 🎉 I added a pin refresh once the pin is successfully added, but the UI is too quick, and actually refreshes too quickly so that the pin you just added doesn't show up and you still need a manual refresh of the page, which is annoying. Do you have an idea @FSM1 or @tanmoyAtb how to work around that? Should we listen to the upload callback in the call or something similar (as you can tell, I've no clue what I'm talking about :D ) |
From what I see, the refresh gets called, only after the add pin API has responded, don't really see a way of getting around it, Currently the pins API only returns pins with |
Thanks Tanmoy, I thought we weren't filtering anything. Would you mind pointing me to where you found it, I couldn't find anything? |
…into feat/import-pin-1105
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
closes #1105
Getting an error when executing the add pin, not sure if that's expected or not
edit (tbaut): solved