Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage buckets overview #1140

Merged
merged 69 commits into from
Jun 18, 2021
Merged

Storage buckets overview #1140

merged 69 commits into from
Jun 18, 2021

Conversation

FSM1
Copy link
Contributor

@FSM1 FSM1 commented Jun 15, 2021

Closes #1104

FSM1 and others added 30 commits May 18, 2021 14:22
@FSM1
fix broken things
0bed9ca
@FSM1
rewire for new apis
0a327c1
@actions-user
lingui extract
cce9198
@FSM1
clean up linting errors
6bbb233
@FSM1
Align paths and test
6bda362
@FSM1
Merge remote-tracking branch 'origin/dev' into mnt/update-api-client-…
d8e2997 
…1008
@FSM1
post merge fixes
5b2d466
@FSM1 @tanmoyAtb
Apply suggestions from code review
331deef 
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
@FSM1 @tanmoyAtb
Update packages/files-ui/src/Utils/pathUtils.ts
d96583b 
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
@FSM1
Merge remote-tracking branch 'origin/dev' into mnt/update-api-client-…
c66e332 
…1008
@FSM1
update context and hook names
7cb0cb0
@FSM1
fix search
fbb22c1
@FSM1
fix bin folder navigation
09bfff7
@FSM1
fix grid item navigation
6d6eebc
@Tbaut
init
702e554
@Tbaut
add permission to buckets
2e0e6ad
@Tbaut
Nav and filtering
d687229
@Tbaut
merge dev and fix conflicts
d1f28d6
@actions-user
lingui extract
678613f
@Tbaut
with some todos
a62c580
@Tbaut
Merge branch 'feat/tbaut-shared-overview-1041' of github.com:ChainSaf…
c0dbea3 
…e/files-ui into feat/tbaut-shared-overview-1041
@Tbaut
merge dev
e855e8e
@Tbaut
lint
d5417d5
@Tbaut
Merge branch 'dev' into feat/tbaut-shared-overview-1041
4c3378c
@Tbaut
basics
c976022
@actions-user
lingui extract
c38c7c7
@Tbaut
User circles
edd8d71
@Tbaut
Merge branch 'feat/tbaut-shared-overview-1041' of github.com:ChainSaf…
c55af18 
…e/files-ui into feat/tbaut-shared-overview-1041
@Tbaut
Merge branch 'dev' into feat/tbaut-shared-overview-1041
9ebd6b7
@FSM1
add storage bucket list and bucket details
6095398
tanmoyAtb
tanmoyAtb requested changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is lit!
The implementation with the file browser works very well!
I think some of the shared overview code got into this PR, I avoided checking them here.

packages/storage-ui/src/Components/Elements/BucketRow.tsx Show resolved Hide resolved
packages/storage-ui/src/Components/Modules/DownloadProgressModals/index.tsx Show resolved Hide resolved
packages/storage-ui/src/Components/Pages/BucketPage.tsx Outdated Show resolved Hide resolved
packages/storage-ui/src/Components/StorageRoutes.tsx Show resolved Hide resolved
packages/storage-ui/src/Components/Elements/BucketRow.tsx Show resolved Hide resolved
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 18, 2021 •
edited
Loading

@tanmoyAtb

I think some of the shared overview code got into this PR, I avoided checking them here.

that's my fault, my branch has almost the same name (overview) and the same number (1014 or something) which was enough for me to mix them. let me check and revert that commit that I must have forgotten to revert.

Tbaut and others added 2 commits June 18, 2021 14:26
@Tbaut
Revert "Merge branch 'feat/tbaut-shared-overview-1041' of github.com:…
5f9bd2d 
…ChainSafe/files-ui into feat/storage-buckets-overview-1104"

This reverts commit 6c8a65a, reversing
changes made to bdf5fdc.
@FSM1 @Tbaut @tanmoyAtb
Apply suggestions from code review
f98a3a5 
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Tanmoy Basak Anjan <tanmoy3399@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2021

This pull request introduces 4 alerts when merging f98a3a5 into b51e6ff - view on LGTM.com

new alerts:

  • 4 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2021

This pull request introduces 2 alerts when merging 0c0e743 into b51e6ff - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@FSM1 FSM1 requested a review from tanmoyAtb June 18, 2021 16:29
@lgtm-com
Copy link

lgtm-com bot commented Jun 18, 2021

This pull request introduces 1 alert when merging 131b9ec into b51e6ff - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

tanmoyAtb
tanmoyAtb approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@tanmoyAtb tanmoyAtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@FSM1 FSM1 merged commit 28f5419 into dev Jun 18, 2021
@FSM1 FSM1 deleted the feat/storage-buckets-overview-1104 branch June 18, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaut Tbaut Tbaut approved these changes

@tanmoyAtb tanmoyAtb tanmoyAtb approved these changes

Assignees
No one assigned
Labels
Status: Review Needed 👀 Added to PRs when they need more review Type: Feature Added to PRs to identify that the change is a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Storage Buckets overview
5 participants
@FSM1 @CLAassistant @Tbaut @tanmoyAtb @actions-user