-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ui tests for folder creation and deletion #1383
Conversation
Your Render PR Server URL is https://gaming-ui-stage-pr-1383.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c41otdk6fj33qkbp9fag. |
Your Render PR Server URL is https://storage-ui-stage-pr-1383.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c41ote46fj33qkbp9fk0. |
Your Render PR Server URL is https://files-ui-stage-pr-1383.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c41otec6fj33qkbp9g0g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working really well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Just like the file creation, it'd be good to test the validation as well (with a /)
I'll make sure to create an issue to have the folder creation automated with a command. We shouldn't do like for upload and do it using the ui.
closes #1380
Needed to do this before I add the file / folder recovery work in another ticket
Had to add the same temp workarounds to commands.ts that I'd previously added for storage. That will be improved in a separate ticket (Resolve issues with local session being cleared after calling cy.reload #1381).
Added
safeClick
command to resolve timing issues between app / cypress when clicking elements (detached from DOM / false successful click etc). Just a temp solution until Cypress add their own ability to retry on the native click command.