Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ui tests for folder creation and deletion #1383

Merged
merged 10 commits into from
Aug 4, 2021

Conversation

asnaith
Copy link
Member

@asnaith asnaith commented Jul 30, 2021

closes #1380

  • Needed to do this before I add the file / folder recovery work in another ticket

  • Had to add the same temp workarounds to commands.ts that I'd previously added for storage. That will be improved in a separate ticket (Resolve issues with local session being cleared after calling cy.reload #1381).

  • Added safeClick command to resolve timing issues between app / cypress when clicking elements (detached from DOM / false successful click etc). Just a temp solution until Cypress add their own ability to retry on the native click command.

@render
Copy link

render bot commented Jul 30, 2021

@render
Copy link

render bot commented Jul 30, 2021

@render
Copy link

render bot commented Jul 30, 2021

@github-actions github-actions bot added the Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes. label Jul 30, 2021
@asnaith asnaith marked this pull request as ready for review August 3, 2021 19:33
Copy link
Contributor

@FSM1 FSM1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working really well :)

Copy link
Collaborator

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Just like the file creation, it'd be good to test the validation as well (with a /)
I'll make sure to create an issue to have the folder creation automated with a command. We shouldn't do like for upload and do it using the ui.

@Tbaut Tbaut enabled auto-merge (squash) August 4, 2021 16:37
@Tbaut Tbaut merged commit d60b8b2 into dev Aug 4, 2021
@Tbaut Tbaut deleted the mnt/add-create-folder-test-1380 branch August 4, 2021 16:39
@FSM1 FSM1 mentioned this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Added to issues and PRs when a change is for repository maintenance , such as CI or linter changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Cypress test to add and delete folders
3 participants